Skip to content

perf(linter/plugins): pre-define less CFG merger functions #20317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Mar 13, 2026
+6 −24
Merged

perf(linter/plugins): pre-define less CFG merger functions #20317

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 6 additions & 24 deletions apps/oxlint/src-js/plugins/visitor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,8 +623,8 @@ function mergeVisitFns(visitProps: VisitProp[]): VisitFn {
* The merged function is statically defined and does not contain a loop, to hopefully allow
* JS engine to heavily optimize it.
*
* `cfgMergers` contains pre-defined functions to merge up to 5 CFG visit functions.
* Merger functions for merging more than 5 visit functions are created dynamically on demand.
* `cfgMergers` contains pre-defined functions to merge up to 3 CFG visit functions.
* Merger functions for merging more than 3 visit functions are created dynamically on demand.
*
* @param visitProps - Array of `CfgVisitProp` objects
* @returns Function which calls all CFG visit functions in turn
Expand Down Expand Up @@ -745,7 +745,10 @@ const mergers: (Merger | null)[] = [
},
];

// Pre-defined CFG mergers for merging up to 5 functions
// Pre-defined CFG mergers for merging up to 3 functions.
//
// CFG event handlers are rarely used, so we only pre-define mergers for up to 3 functions,
// unlike the AST node visit fns, where we pre-define 5.
const cfgMergers: (CfgMerger | null)[] = [
null, // No merger for 0 functions
null, // No merger for 1 function
Expand All @@ -760,25 +763,4 @@ const cfgMergers: (CfgMerger | null)[] = [
visit2(...args);
visit3(...args);
},
(visit1: CfgVisitFn, visit2: CfgVisitFn, visit3: CfgVisitFn, visit4: CfgVisitFn) =>
(...args: unknown[]) => {
visit1(...args);
visit2(...args);
visit3(...args);
visit4(...args);
},
(
visit1: CfgVisitFn,
visit2: CfgVisitFn,
visit3: CfgVisitFn,
visit4: CfgVisitFn,
visit5: CfgVisitFn,
) =>
(...args: unknown[]) => {
visit1(...args);
visit2(...args);
visit3(...args);
visit4(...args);
visit5(...args);
},
];
Loading