test(oxfmt/lsp): snapshot fixture uri instead of (fake) path#19883
Merged
graphite-app[bot] merged 1 commit intomainfrom Mar 2, 2026
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-cli
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the oxfmt LSP test snapshot output to record a stable, sanitized document URI instead of a fixture “path”, improving portability across machines and environments.
Changes:
- Replace the snapshot header from
--- FILE+ relative path to--- URI+ sanitized URI. - Add
uriSnapshotHeader()helper to normalize fixture file URIs tofile://<fixture>/.... - Update Vitest snapshot files to match the new header/output format.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/oxfmt/test/lsp/utils.ts | Introduces uriSnapshotHeader() and switches snapshot output to a URI-based header with fixture URI sanitization. |
| apps/oxfmt/test/lsp/format/snapshots/format.test.ts.snap | Updates snapshots to expect --- URI and sanitized fixture/in-memory URIs. |
| apps/oxfmt/test/lsp/did_change_configuration/snapshots/format_after_config_change.test.ts.snap | Updates snapshots to expect --- URI and sanitized fixture URIs. |
Member
Merge activity
|
Because we are not testing URIs where there should be no local file related to it, it is better to show the URI
graphite-app
bot
force-pushed
the
03-01-feat_oxfmt_lsp_support_other_schemes_beside_file___and_untitled___
branch
from
3ec5794 to
4888a99
Compare
graphite-app
bot
force-pushed
the
03-01-test_oxfmt_lsp_snapshot_fixture_uri_instead_of_fake_path
branch
from
817286f to
3415cf8
Compare
Base automatically changed from
03-01-feat_oxfmt_lsp_support_other_schemes_beside_file___and_untitled___
to
main
March 2, 2026 00:40
graphite-app
bot
deleted the
03-01-test_oxfmt_lsp_snapshot_fixture_uri_instead_of_fake_path
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because we are not testing URIs where there should be no local file related to it, it is better to show the URI