Skip to content

fix(lsp): handle other schemes (besides from file and untitled)#19871

Merged
graphite-app[bot] merged 1 commit intomainfrom
03-01-fix_lsp_handle_other_schemes_besides_from_file_and_untitled_
Mar 2, 2026
Merged

fix(lsp): handle other schemes (besides from file and untitled)#19871
graphite-app[bot] merged 1 commit intomainfrom
03-01-fix_lsp_handle_other_schemes_besides_from_file_and_untitled_

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Mar 1, 2026

This PR updates workspace-worker selection in the language server so that documents using non-file URI schemes (e.g. VS Code in-memory/userdata URIs) can still be associated with a workspace worker.

Copy link
Member Author

Sysix commented Mar 1, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-editor Area - Editor and Language Server C-bug Category - Bug labels Mar 1, 2026
@Sysix Sysix requested a review from Copilot March 1, 2026 12:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates workspace-worker selection in the language server so that documents using non-file URI schemes (e.g. VS Code in-memory/userdata URIs) can still be associated with a workspace worker.

Changes:

  • Adjust find_worker_for_uri to fall back to the first workspace worker for any non-file URI scheme.
  • Update inline documentation to reflect the new non-file behavior.
  • Update/rename a unit test to cover vscode-userdata: URIs.

@Sysix Sysix force-pushed the 03-01-fix_lsp_handle_other_schemes_besides_from_file_and_untitled_ branch from 66c162a to 1a228e5 Compare March 1, 2026 12:51
@Sysix Sysix marked this pull request as ready for review March 1, 2026 12:58
@Sysix Sysix requested a review from camc314 as a code owner March 1, 2026 12:59
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Mar 2, 2026
@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 2, 2026

Merge activity

> This PR updates workspace-worker selection in the language server so that documents using non-`file` URI schemes (e.g. VS Code in-memory/userdata URIs) can still be associated with a workspace worker.
@graphite-app graphite-app bot force-pushed the 03-01-fix_lsp_handle_other_schemes_besides_from_file_and_untitled_ branch from 1a228e5 to 74a3078 Compare March 2, 2026 00:32
@graphite-app graphite-app bot merged commit 74a3078 into main Mar 2, 2026
21 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Mar 2, 2026
@graphite-app graphite-app bot deleted the 03-01-fix_lsp_handle_other_schemes_besides_from_file_and_untitled_ branch March 2, 2026 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-editor Area - Editor and Language Server C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants