Skip to content

fix(linter): unicorn/no-array-callback-reference skip Effect.* array-like methods name. #19633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camc314 merged 1 commit into from
Feb 23, 2026
Merged

fix(linter): unicorn/no-array-callback-reference skip Effect.* array-like methods name. #19633

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions crates/oxc_linter/src/rules/unicorn/no_array_callback_reference.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ use oxc_diagnostics::OxcDiagnostic;
use oxc_macros::declare_oxc_lint;
use oxc_span::{GetSpan, Span};

use crate::{AstNode, ast_util::is_method_call, context::LintContext, rule::Rule};
use crate::{
AstNode, ast_util::is_method_call, context::LintContext, rule::Rule, utils::is_import_symbol,
};

fn no_array_callback_reference_diagnostic(span: Span) -> OxcDiagnostic {
OxcDiagnostic::warn("Avoid passing a function reference directly to iterator methods")
Expand Down Expand Up @@ -94,7 +96,7 @@ impl Rule for NoArrayCallbackReference {
}

let object = member_expr.object();
if is_ignored_object(object) {
if is_ignored_object(object, ctx) {
return;
}

Expand Down Expand Up @@ -196,9 +198,13 @@ fn is_allowed_builtin(name: &str) -> bool {
)
}

fn is_ignored_object(expr: &Expression) -> bool {
fn is_ignored_object(expr: &Expression, ctx: &LintContext<'_>) -> bool {
match expr {
Expression::Identifier(ident) => {
if is_import_symbol(ident, "effect", "Effect", ctx) {
return true;
}

matches!(
ident.name.as_str(),
"Promise"
Expand Down Expand Up @@ -298,6 +304,7 @@ fn test() {
"foo.reduce(_ ? () => {} : _ ? () => {} : () => {})",
"foo.every(_ ? Boolean : _ ? Boolean : Boolean)",
"foo.map(_ ? String : _ ? Number : Boolean)",
r#"import { Effect as E } from "effect"; const foo = "boo"; E.some(foo)"#,
];

let fail = vec![
Expand Down
Loading