Skip to content

perf(linter/constructor-super): use node_id over nodes loop #19489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Feb 17, 2026
Merged

perf(linter/constructor-super): use node_id over nodes loop #19489

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions crates/oxc_linter/src/rules/eslint/constructor_super.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,14 +216,7 @@ impl Rule for ConstructorSuper {

let cfg = ctx.cfg();

// Find constructor's CFG entry block
// TODO: this is expensive, we should have a direct mapping from function AST to node id (and then to CFG block)
let constructor_func_node = ctx.nodes().iter().find(
|n| matches!(n.kind(), AstKind::Function(func) if func.span == constructor.value.span),
);

let Some(constructor_func_node) = constructor_func_node else { return };
let constructor_block_id = ctx.nodes().cfg_id(constructor_func_node.id());
let constructor_block_id = ctx.nodes().cfg_id(constructor.value.node_id());

let (super_call_counts, super_call_spans) =
Self::find_super_calls_in_cfg(cfg, constructor_block_id, node.id(), ctx);
Expand Down
Loading