refactor(linter/consistent-indexed-object-style): use symbol references over AST traversal#19321
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Pull request overview
This PR refactors the consistent-indexed-object-style TypeScript lint rule to detect mapped-type key usage via semantic symbol references rather than manually traversing the TypeScript type AST, aiming to reduce complexity and improve correctness around shadowing.
Changes:
- Replaces deep
TSTypeAST traversal for “does value reference mapped key?” with a semanticsymbol_references-based check scoped to the mapped value type span. - Simplifies imports and removes the now-unneeded recursive helper functions for identifier matching within types.
Merging this PR will not alter performance
Comparing Footnotes
|
Merge activity
|
…es over AST traversal (#19321)
416dceb to
b7ef0a8
Compare
6efd6ad to
cf3a8fc
Compare

No description provided.