Skip to content

refactor(linter/consistent-indexed-object-style): use symbol references over AST traversal#19321

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/02-12-refactor_linter_consistent-indexed-object-style_use_symbol_references_over_ast_traversal
Feb 12, 2026
Merged

refactor(linter/consistent-indexed-object-style): use symbol references over AST traversal#19321
graphite-app[bot] merged 1 commit intomainfrom
c/02-12-refactor_linter_consistent-indexed-object-style_use_symbol_references_over_ast_traversal

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Feb 12, 2026

No description provided.

Copy link
Contributor Author

camc314 commented Feb 12, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the A-linter Area - Linter label Feb 12, 2026
@camc314 camc314 marked this pull request as ready for review February 12, 2026 12:36
@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label Feb 12, 2026
Copilot AI review requested due to automatic review settings February 12, 2026 12:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the consistent-indexed-object-style TypeScript lint rule to detect mapped-type key usage via semantic symbol references rather than manually traversing the TypeScript type AST, aiming to reduce complexity and improve correctness around shadowing.

Changes:

  • Replaces deep TSType AST traversal for “does value reference mapped key?” with a semantic symbol_references-based check scoped to the mapped value type span.
  • Simplifies imports and removes the now-unneeded recursive helper functions for identifier matching within types.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 12, 2026

Merging this PR will not alter performance

✅ 47 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing c/02-12-refactor_linter_consistent-indexed-object-style_use_symbol_references_over_ast_traversal (cf3a8fc) with main (9f65861)2

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (cf3a8fc) during the generation of this report, so 9f65861 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 12, 2026

Merge activity

@graphite-app graphite-app bot force-pushed the c/02-12-fix_linter_consistent-indexed-object-style_avoid_unsafe_record_conversions_for_mapped_types branch from 416dceb to b7ef0a8 Compare February 12, 2026 12:47
@graphite-app graphite-app bot force-pushed the c/02-12-refactor_linter_consistent-indexed-object-style_use_symbol_references_over_ast_traversal branch from 6efd6ad to cf3a8fc Compare February 12, 2026 12:48
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Feb 12, 2026
Base automatically changed from c/02-12-fix_linter_consistent-indexed-object-style_avoid_unsafe_record_conversions_for_mapped_types to main February 12, 2026 12:53
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 12, 2026
@graphite-app graphite-app bot merged commit cf3a8fc into main Feb 12, 2026
30 checks passed
@graphite-app graphite-app bot deleted the c/02-12-refactor_linter_consistent-indexed-object-style_use_symbol_references_over_ast_traversal branch February 12, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants