fix(linter/consistent-indexed-object-style): avoid unsafe Record conversions for mapped types by camc314 · Pull Request #19320 · oxc-project/oxc

camc314 · 2026-02-12T12:34:03Z

fixes #19317

camc314 · 2026-02-12T12:34:16Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copilot

Pull request overview

This PR tightens the consistent-indexed-object-style TypeScript linter rule to avoid suggesting unsafe Record<...> conversions for mapped types that can’t be represented faithfully (e.g., key remapping) and improves detection of mapped-key references inside more TypeScript type constructs.

Changes:

Skip Record conversions for mapped types that use key remapping (as).
Expand references_identifier to detect mapped-key references in more TSType variants and in type-literal signatures/parameter types.
Add regression tests covering mapped types whose value types reference the mapped key and key-remapping cases.

crates/oxc_linter/src/rules/typescript/consistent_indexed_object_style.rs

codspeed-hq · 2026-02-12T12:39:44Z

Merging this PR will not alter performance

✅ 47 untouched benchmarks
⏩ 3 skipped benchmarks¹

_{Comparing c/02-12-fix_linter_consistent-indexed-object-style_avoid_unsafe_record_conversions_for_mapped_types (b7ef0a8) with main (9f65861)²}

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on main (b7ef0a8) during the generation of this report, so 9f65861 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

graphite-app · 2026-02-12T12:45:53Z

Merge activity

Feb 12, 12:45 PM UTC: camc314 added this pull request to the Graphite merge queue.
Feb 12, 12:53 PM UTC: Merged by the Graphite merge queue.

…ersions for mapped types (#19320) fixes #19317

# Oxlint ### 💥 BREAKING CHANGES - 7711821 oxlint: [**BREAKING**] `no-shadow-restricted-names` report `globalThis` by default (#19407) (Sysix) ### 🚀 Features - ce1baa0 linter: Implement eslint/no-shadow (#18979) (Víctor Fernández) - 7a333c1 linter: Support dynamic configs via CLI arguments (#19384) (camc314) - 1bf569b linter: Implement typescript/unified-signatures (#19375) (camc314) - 6562a9b linter: Implement typescript/parameter-properties (#19374) (camc314) - 94d8d74 linter: Implement typescript/no-use-before-define (#19373) (camc314) - 80b002a linter: Implement fixer for unicorn/no-instanceof-builtins (#19371) (camc314) - 5c3784b linter: Implement eslint/no-unmodified-loop-condition (#19341) (Vincent R) - cc00a59 linter/const-comparisons: Improve diagnostics when mixing logical/comparison operators (#19370) (camc314) - ea2c401 linter: Add support for no constructed context values (#18067) (Jovi De Croock) - f2440eb linter: Mark eslint/no-return-assign as having no fixer (#19327) (camc314) - 8588670 linter/unicorn: Implement suggestion for `unicorn/no-await-in-promise-methods` rule (#19359) (Mikhail Baev) - f0af965 linter: Move `jsx-a11y/no-static-element-interactions` rule out of the nursery. (#19355) (connorshea) - be0ce50 linter/tsgolint: Add support for labeled ranges in tsgolint diagnostics (#19201) (camchenry) - b5bc900 linter: Implement fixer for unicorn/no-new-buffer (#19326) (camc314) - 1612932 linter: Add typescript/no-unnecessary-condition (#19130) (camc314) - 37dc6c5 linter: Implement fixer for unicorn/prefer-includes (#19323) (camc314) ### 🐛 Bug Fixes - c2b1870 linter: Enforce config options for `react/forbid-dom-props` rule. (#19387) (connorshea) - 3d24e44 linter: Honor no-empty-function allow getters/setters for object literals (#19393) (camc314) - bbced8d linter: Enforce config options for `eslint/no-empty-function` rule, improve docs. (#19390) (connorshea) - 6bc8aec linter: Fix the behavior of `import/extensions` rule for a file that has multiple extensions. (#18919) (connorshea) - c62a295 linter/img-redundant-alt: Enforce whole-word matching for redundant alt text (#19367) (camc314) - 98956fe linter/describe-function-title: Skip autofix for type-only imports (#19329) (camc314) - d96d26d linter/plugins: Provide `parser.version` (#19364) (overlookmotel) - 81f0039 linter_codegen: Compute rule IDs relative to previous rule (#19350) (camchenry) - b7ef0a8 linter/consistent-indexed-object-style: Avoid unsafe Record conversions for mapped types (#19320) (camc314) ### 📚 Documentation - 3a6059f linter: Improve docs for `eslint/require-await` rule. (#19361) (connorshea) - b069269 linter/plugins: Add comment about deprecated `ScopeManager` methods (#19363) (overlookmotel) - 2d8aaf9 linter: Disable formatting for `eslint/no-unsafe-negation` examples. (#19347) (connorshea) - fb87806 linter: Ensure that we do not auto-format the docs for `unicorn/number-literal-case` rule. (#19346) (connorshea) - 8d3ae27 linter/typescript: Skip docs for deprecated type aware rule options (#19324) (camc314) # Oxfmt ### 💥 BREAKING CHANGES - 00135b5 formatter/sort_imports: [**BREAKING**] Change default `groups` order (#19427) (leaysgur) - 9c34f72 formatter/sort_imports: [**BREAKING**] Report invalid group name with renaming `side-effect` > `side_effect` (#19416) (leaysgur) ### 🚀 Features - 4baebef formatter/sort_imports: Support `{ newlinesBetween: bool }` inside `groups` (#19358) (leaysgur) - d1c2fb6 formatter/sort_imports: Support `customGroups` attributes(`selector` and `modifiers`) (#19356) (leaysgur) ### 🐛 Bug Fixes - f084ea6 oxfmt: Explicitly pass `process.env` for the forked process (#19380) (Long Ho) - 2bc7a14 formatter: Arrow function body incorrectly broken when return type has comment (#19368) (Dunqing) - 90ec3d2 oxfmt: Update tailwind plugin which fixes crash on non-js file (#19353) (leaysgur) - e9c5b1e formatter: Treat `PrivateFieldExpression` as simple call argument (#19348) (Dunqing) - 80643d5 formatter: Match Prettier union indentation with leading comments (#19271) (Dunqing) ### ⚡ Performance - c169c77 syntax: Optimize `is_identifier_name_patched` (#19386) (sapphi-red)

camc314 marked this pull request as ready for review February 12, 2026 12:34

Copilot AI review requested due to automatic review settings February 12, 2026 12:34

github-actions bot added A-linter Area - Linter C-bug Category - Bug labels Feb 12, 2026

camc314 self-assigned this Feb 12, 2026

Copilot started reviewing on behalf of camc314 February 12, 2026 12:34 View session

camc314 mentioned this pull request Feb 12, 2026

refactor(linter/consistent-indexed-object-style): use symbol references over AST traversal #19321

Merged

Copilot AI reviewed Feb 12, 2026

View reviewed changes

fix(linter/consistent-indexed-object-style): avoid unsafe Record conv…

b7ef0a8

…ersions for mapped types (#19320) fixes #19317

graphite-app bot force-pushed the c/02-12-fix_linter_consistent-indexed-object-style_avoid_unsafe_record_conversions_for_mapped_types branch from 416dceb to b7ef0a8 Compare February 12, 2026 12:47

camc314 added the 0-merge Merge with Graphite Merge Queue label Feb 12, 2026

graphite-app bot merged commit b7ef0a8 into main Feb 12, 2026
29 checks passed

graphite-app bot deleted the c/02-12-fix_linter_consistent-indexed-object-style_avoid_unsafe_record_conversions_for_mapped_types branch February 12, 2026 12:53

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 12, 2026

Boshen mentioned this pull request Feb 16, 2026

release(apps): oxlint v1.48.0 && oxfmt v0.33.0 #19430

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(linter/consistent-indexed-object-style): avoid unsafe Record conversions for mapped types#19320

fix(linter/consistent-indexed-object-style): avoid unsafe Record conversions for mapped types#19320
graphite-app[bot] merged 1 commit intomainfrom
c/02-12-fix_linter_consistent-indexed-object-style_avoid_unsafe_record_conversions_for_mapped_types

camc314 commented Feb 12, 2026 •

edited

Loading

Uh oh!

camc314 commented Feb 12, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codspeed-hq bot commented Feb 12, 2026 •

edited

Loading

Uh oh!

graphite-app bot commented Feb 12, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

camc314 commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

camc314 commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codspeed-hq bot commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

graphite-app bot commented Feb 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

camc314 commented Feb 12, 2026 •

edited

Loading

camc314 commented Feb 12, 2026 •

edited

Loading

codspeed-hq bot commented Feb 12, 2026 •

edited

Loading

graphite-app bot commented Feb 12, 2026 •

edited

Loading