refactor(oxlint): enable useUnknownInCatchVariables tsconfig setting#19141
Merged
graphite-app[bot] merged 1 commit intomainfrom Feb 9, 2026
Conversation
github-actions
bot
added
A-linter
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull request overview
Enables TypeScript’s useUnknownInCatchVariables for the oxlint app and updates a few catch blocks/call sites to satisfy the stricter typing.
Changes:
- Enable
useUnknownInCatchVariablesinapps/oxlint/tsconfig.json. - Update test/conformance helpers to type/narrow caught errors.
- Adjust RuleTester option-serialization error handling to compile under the new setting.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/oxlint/tsconfig.json | Turns on useUnknownInCatchVariables for stricter catch-variable typing. |
| apps/oxlint/test/utils.ts | Narrows file read errors to check code safely. |
| apps/oxlint/test/rule_tester.test.ts | Adds explicit typing/casts around captured test errors. |
| apps/oxlint/test/fixtures/createOnce/plugin.ts | Updates fixture helper signature/cast for unknown catch variables. |
| apps/oxlint/src-js/package/rule_tester.ts | Adjusts error formatting in JSON serialization catch path. |
| apps/oxlint/conformance/src/capture.ts | Refactors catch handling to avoid reassigning catch variables and to normalize error type. |
graphite-app
bot
changed the base branch from
c/02-08-chore_all_explicitly_set_strict_false_in_tsconfigs
to
graphite-base/19141
Contributor
Author
Merge activity
|
camc314
force-pushed
the
graphite-base/19141
branch
from
36f3872 to
00d431d
Compare
camc314
force-pushed
the
c/02-08-refactor_oxlint_enable_useunknownincatchvariables_tsconfig_setting
branch
from
85b05e0 to
dda6e9b
Compare
camc314
force-pushed
the
c/02-08-refactor_oxlint_enable_useunknownincatchvariables_tsconfig_setting
branch
from
dda6e9b to
1be39a7
Compare
graphite-app
bot
force-pushed
the
c/02-08-refactor_oxlint_enable_useunknownincatchvariables_tsconfig_setting
branch
from
1be39a7 to
d4b0324
Compare
graphite-app
bot
deleted the
c/02-08-refactor_oxlint_enable_useunknownincatchvariables_tsconfig_setting
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.