Skip to content

chore(oxlint,parser,e2e): explicitly set strict: false in tsconfigs#19129

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/02-08-chore_all_explicitly_set_strict_false_in_tsconfigs
Feb 9, 2026
Merged

chore(oxlint,parser,e2e): explicitly set strict: false in tsconfigs#19129
graphite-app[bot] merged 1 commit intomainfrom
c/02-08-chore_all_explicitly_set_strict_false_in_tsconfigs

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Feb 8, 2026

fixes the failures seen in #19128

Copy link
Contributor Author

camc314 commented Feb 8, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-linter Area - Linter A-parser Area - Parser A-cli Area - CLI C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Feb 8, 2026
@camc314 camc314 marked this pull request as ready for review February 8, 2026 01:25
Copilot AI review requested due to automatic review settings February 8, 2026 01:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses CI/tooling failures introduced after updating oxlint-tsgolint by making TypeScript strictness behavior explicit in selected tsconfig.json files.

Changes:

  • Add compilerOptions.strict: false to tasks/e2e/tsconfig.json.
  • Add compilerOptions.strict: false to napi/parser/tsconfig.json.
  • Add compilerOptions.strict: false to apps/oxlint/tsconfig.json.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
tasks/e2e/tsconfig.json Makes strictness explicit for the e2e TS config.
napi/parser/tsconfig.json Makes strictness explicit for the N-API parser TS config.
apps/oxlint/tsconfig.json Makes strictness explicit in the oxlint app TS config (in addition to existing strict sub-flags).

@camc314 camc314 changed the title chore(all): explicitly set strict: false in tsconfigs chore(olxint,parser,e2e): explicitly set strict: false in tsconfigs Feb 8, 2026
@camc314 camc314 changed the title chore(olxint,parser,e2e): explicitly set strict: false in tsconfigs chore(oxlint,parser,e2e): explicitly set strict: false in tsconfigs Feb 8, 2026
Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we fix these strict errors

@camc314
Copy link
Contributor Author

camc314 commented Feb 8, 2026

should we fix these strict errors

can we do this in a follow up?

this stops the tsgolint bump from being merged.

@connorshea
Copy link
Member

connorshea commented Feb 9, 2026

Given that one of the changes necessary to enable strict mode is quite significant, I think we should do that as a (high-priority) follow-up yeah

@camc314
Copy link
Contributor Author

camc314 commented Feb 9, 2026

I need to merge this one as it blocks us upgrading oxlint-tsgolint to the latest version.

This change doesn't actually change how we're typechecking these files, it just makes the setting explicit over implicit.

I've made a few follow up PRs to fix the issues

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Feb 9, 2026
@camc314 camc314 self-assigned this Feb 9, 2026
Copy link
Contributor Author

camc314 commented Feb 9, 2026

Merge activity

@graphite-app graphite-app bot force-pushed the c/02-08-chore_all_explicitly_set_strict_false_in_tsconfigs branch from 36f3872 to 00d431d Compare February 9, 2026 09:35
@graphite-app graphite-app bot merged commit 00d431d into main Feb 9, 2026
19 checks passed
@graphite-app graphite-app bot deleted the c/02-08-chore_all_explicitly_set_strict_false_in_tsconfigs branch February 9, 2026 09:41
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants