chore(oxlint,parser,e2e): explicitly set strict: false in tsconfigs#19129
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Pull request overview
This PR addresses CI/tooling failures introduced after updating oxlint-tsgolint by making TypeScript strictness behavior explicit in selected tsconfig.json files.
Changes:
- Add
compilerOptions.strict: falsetotasks/e2e/tsconfig.json. - Add
compilerOptions.strict: falsetonapi/parser/tsconfig.json. - Add
compilerOptions.strict: falsetoapps/oxlint/tsconfig.json.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tasks/e2e/tsconfig.json | Makes strictness explicit for the e2e TS config. |
| napi/parser/tsconfig.json | Makes strictness explicit for the N-API parser TS config. |
| apps/oxlint/tsconfig.json | Makes strictness explicit in the oxlint app TS config (in addition to existing strict sub-flags). |
strict: false in tsconfigsstrict: false in tsconfigs
strict: false in tsconfigsstrict: false in tsconfigs
Boshen
left a comment
There was a problem hiding this comment.
should we fix these strict errors
can we do this in a follow up? this stops the tsgolint bump from being merged. |
|
Given that one of the changes necessary to enable strict mode is quite significant, I think we should do that as a (high-priority) follow-up yeah |
|
I need to merge this one as it blocks us upgrading oxlint-tsgolint to the latest version. This change doesn't actually change how we're typechecking these files, it just makes the setting explicit over implicit. I've made a few follow up PRs to fix the issues |
Merge activity
|
36f3872 to
00d431d
Compare

fixes the failures seen in #19128