Skip to content

fix(linter/react/no-unknown-property): add missing popover related props #18953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camc314 merged 1 commit into from
Feb 5, 2026
Merged

fix(linter/react/no-unknown-property): add missing popover related props #18953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion crates/oxc_linter/src/rules/react/no_unknown_property.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,9 @@ const ATTRIBUTE_TAGS_MAP: Map<&'static str, Set<&'static str>> = phf_map! {
"imageSizes" => phf_set! {"link"},
"imageSrcSet" => phf_set! {"link"},
"property" => phf_set! {"meta"},
// https://html.spec.whatwg.org/multipage/popover.html#the-popovertarget-attribute
"popoverTarget" => phf_set! {"button", "input"},
"popoverTargetAction" => phf_set! {"button", "input"},
"viewBox" => phf_set! {"marker", "pattern", "svg", "symbol", "view"},
"as" => phf_set! {"link"},
"align" => phf_set! {
Expand Down Expand Up @@ -196,7 +199,7 @@ const ATTRIBUTE_TAGS_MAP: Map<&'static str, Set<&'static str>> = phf_map! {
const DOM_PROPERTIES_NAMES: Set<&'static str> = phf_set! {
// Global attributes - can be used on any HTML/DOM element
// See https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes
"dir", "draggable", "hidden", "id", "lang", "nonce", "part", "slot", "style", "title", "translate", "inert",
"dir", "draggable", "hidden", "id", "lang", "nonce", "part", "popover", "slot", "style", "title", "translate", "inert",
// Element specific attributes
// See https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes (includes global attributes too)
// To be considered if these should be added also to ATTRIBUTE_TAGS_MAP
Expand Down Expand Up @@ -332,6 +335,8 @@ const DOM_ATTRIBUTES_TO_CAMEL: Map<&'static str, &'static str> = phf_map! {
"crossorigin" => "crossOrigin",
"for" => "htmlFor",
"nomodule" => "noModule",
"popovertarget" => "popoverTarget",
"popovertargetaction" => "popoverTargetAction",
// svg
"accent-height" => "accentHeight",
"alignment-baseline" => "alignmentBaseline",
Expand Down Expand Up @@ -674,6 +679,12 @@ fn test() {
r#"<dialog onClose={handler} open id="dialog" returnValue="something" onCancel={handler2} />"#,
None,
),
(r#"<div popover="auto" />"#, None),
(r#"<button popoverTarget="locale-switcher" popoverTargetAction="show" />"#, None),
(
r#"<input type="button" popoverTarget="locale-switcher" popoverTargetAction="show" />"#,
None,
),
(
r#"
<table align="top">
Expand Down Expand Up @@ -739,6 +750,8 @@ fn test() {
(r#"<div download="foo" />"#, None),
(r#"<div imageSrcSet="someImageSrcSet" />"#, None),
(r#"<div imageSizes="someImageSizes" />"#, None),
(r#"<div popoverTarget="locale-switcher" />"#, None),
(r#"<div popoverTargetAction="show" />"#, None),
(r#"<div data-xml-anything="invalid" />"#, None),
(
r#"<div data-testID="bar" data-under_sCoRe="bar" />;"#,
Expand Down
14 changes: 14 additions & 0 deletions crates/oxc_linter/src/snapshots/react_no_unknown_property.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,20 @@ source: crates/oxc_linter/src/tester.rs
╰────
help: Property 'imageSizes' is only allowed on: link

⚠ eslint-plugin-react(no-unknown-property): Invalid property found
╭─[no_unknown_property.tsx:1:6]
1 │ <div popoverTarget="locale-switcher" />
· ─────────────
╰────
help: Property 'popoverTarget' is only allowed on: input, button

⚠ eslint-plugin-react(no-unknown-property): Invalid property found
╭─[no_unknown_property.tsx:1:6]
1 │ <div popoverTargetAction="show" />
· ───────────────────
╰────
help: Property 'popoverTargetAction' is only allowed on: input, button

⚠ eslint-plugin-react(no-unknown-property): Unknown property found
╭─[no_unknown_property.tsx:1:6]
1 │ <div data-xml-anything="invalid" />
Expand Down
Loading