Skip to content

build(oxlint): generate npm/oxlint-plugins in release CI workflow#18903

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/02-03-build_oxlint_generate_npm_oxlint-plugins_in_release_ci_workflow
Feb 4, 2026
Merged

build(oxlint): generate npm/oxlint-plugins in release CI workflow#18903
graphite-app[bot] merged 1 commit intomainfrom
om/02-03-build_oxlint_generate_npm_oxlint-plugins_in_release_ci_workflow

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Feb 3, 2026

#18824 added @oxlint/plugins package. The files in npm/oxlint-plugins were generated by the build script apps/oxlint/scripts/build.ts.

Instead, populate npm/oxlint-plugins in the release CI workflow, just before the package is published.

Copy link
Member Author

overlookmotel commented Feb 3, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@graphite-app graphite-app bot changed the base branch from om/02-03-build_oxlint_simplify_building_oxlint_plugins_ to graphite-base/18903 February 4, 2026 09:24
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Feb 4, 2026
@overlookmotel overlookmotel marked this pull request as ready for review February 4, 2026 10:34
Copilot AI review requested due to automatic review settings February 4, 2026 10:34
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 4, 2026

Merge activity

  • Feb 4, 10:34 AM UTC: This pull request can not be added to the Graphite merge queue. Please try rebasing and resubmitting to merge when ready.
  • Feb 4, 10:34 AM UTC: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Feb 4, 10:34 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 4, 11:17 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Feb 4, 12:30 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
  • Feb 4, 12:38 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
  • Feb 4, 12:47 PM UTC: Merged by the Graphite merge queue.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Moves generation of the @oxlint/plugins package build artifacts out of the repo and into the release CI workflow, so npm/oxlint-plugins is populated from apps/oxlint/dist-pkg-plugins at publish time.

Changes:

  • Remove committed generated build outputs (index.js, index.cjs, index.d.ts) from npm/oxlint-plugins/.
  • Update apps/oxlint/scripts/build.ts to stop copying plugin artifacts into npm/oxlint-plugins/.
  • Update release CI workflow to copy dist-pkg-plugins outputs into npm/oxlint-plugins/ before publishing.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
npm/oxlint-plugins/index.js Removed generated ESM entrypoint from repo.
npm/oxlint-plugins/index.cjs Removed generated CJS entrypoint from repo.
npm/oxlint-plugins/index.d.ts Removed generated TypeScript declarations from repo.
apps/oxlint/tsdown.config.ts Removes outdated comment about build script moving plugin artifacts.
apps/oxlint/scripts/build.ts Stops copying plugin artifacts into npm/oxlint-plugins/; leaves generation for CI.
.github/workflows/release_apps.yml Adds step to copy dist-pkg-plugins outputs into npm/oxlint-plugins/.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@overlookmotel overlookmotel added 0-merge Merge with Graphite Merge Queue and removed 0-merge Merge with Graphite Merge Queue labels Feb 4, 2026
@overlookmotel overlookmotel force-pushed the om/02-03-build_oxlint_generate_npm_oxlint-plugins_in_release_ci_workflow branch from d4a54e0 to 2e128b1 Compare February 4, 2026 12:29
@overlookmotel overlookmotel changed the base branch from graphite-base/18903 to main February 4, 2026 12:29
@overlookmotel overlookmotel force-pushed the om/02-03-build_oxlint_generate_npm_oxlint-plugins_in_release_ci_workflow branch from 2e128b1 to b25bd74 Compare February 4, 2026 12:32
graphite-app bot pushed a commit that referenced this pull request Feb 4, 2026
…18903)

#18824 added `@oxlint/plugins` package. The files in `npm/oxlint-plugins` were generated by the build script `apps/oxlint/scripts/build.ts`.

Instead, populate `npm/oxlint-plugins` in the release CI workflow, just before the package is published.
@graphite-app graphite-app bot force-pushed the om/02-03-build_oxlint_generate_npm_oxlint-plugins_in_release_ci_workflow branch from b25bd74 to 43007cd Compare February 4, 2026 12:39
…18903)

#18824 added `@oxlint/plugins` package. The files in `npm/oxlint-plugins` were generated by the build script `apps/oxlint/scripts/build.ts`.

Instead, populate `npm/oxlint-plugins` in the release CI workflow, just before the package is published.
@graphite-app graphite-app bot force-pushed the om/02-03-build_oxlint_generate_npm_oxlint-plugins_in_release_ci_workflow branch from 43007cd to 0182779 Compare February 4, 2026 12:40
@graphite-app graphite-app bot merged commit 0182779 into main Feb 4, 2026
21 checks passed
@graphite-app graphite-app bot deleted the om/02-03-build_oxlint_generate_npm_oxlint-plugins_in_release_ci_workflow branch February 4, 2026 12:47
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 4, 2026
graphite-app bot pushed a commit that referenced this pull request Feb 4, 2026
Continuation of #18824, #18828, #18903.

Remove the `oxlint/plugins` export and the `plugins.ts` entry point. These are now only used in tests, where the files can be loaded from `dist-pkg-plugins` instead.

We don't want to encourage people to use `oxlint/plugins` in their plugins - they should be using `@oxlint/plugins` package instead to avoid their plugin having a dependency on `oxlint`.

Due to less shared dependencies between files, this results in 5 less files in `dist` directory in release build.

This also allows re-enabling the debug assertions in this code in tests.
graphite-app bot pushed a commit that referenced this pull request Feb 6, 2026
Boshen pushed a commit that referenced this pull request Feb 11, 2026
…kage (#19234)

#18824 added a `@oxlint/plugins` NPM package, and #18903 altered the
release workflow. It seems neither worked correctly - the package hasn't
been getting published during the release process.

It's still on version 1.43.0 on NPM:
https://www.npmjs.com/package/@oxlint/plugins

This PR alters the pre-release and release workflows to (hopefully) bump
version of this package and release it alongside `oxlint` package.

There have been no changes to content of `@oxlint/plugins` package since
the last published version, and it has no dependencies, so it doesn't
really matter that we've skipped these releases. But this PR should get
it publishing correctly from next release onwards.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants