Skip to content

build(oxlint): simplify building @oxlint/plugins#18902

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/02-03-build_oxlint_simplify_building_oxlint_plugins_
Feb 4, 2026
Merged

build(oxlint): simplify building @oxlint/plugins#18902
graphite-app[bot] merged 1 commit intomainfrom
om/02-03-build_oxlint_simplify_building_oxlint_plugins_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Feb 3, 2026

Follow-on after #18824. Refactor only.

Simplify building @oxlint/plugins package. Generate both the ESM and CommonJS builds in the same directory.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI labels Feb 3, 2026
Copy link
Member Author

overlookmotel commented Feb 3, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the build process for the @oxlint/plugins package to simplify the configuration and build steps. Instead of generating ESM and CommonJS builds into separate subdirectories (esm/ and cjs/) and then copying specific files, both builds now output directly to the same dist-pkg-plugins directory with different file extensions.

Changes:

  • Configured TSDown to output both ESM and CommonJS builds to the same directory (dist-pkg-plugins)
  • Added manual directory cleanup before TSDown runs, with clean: false in the config to prevent TSDown from deleting files between builds
  • Simplified file copying to use a generic loop over all files instead of an explicit file list

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
apps/oxlint/tsdown.config.ts Added outDir and clean: false to pluginsPkgConfig; removed separate outDir overrides for ESM and CommonJS builds
apps/oxlint/scripts/build.ts Added manual deletion of dist-pkg-plugins before build; simplified file copying to loop over all files instead of explicit list

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Feb 4, 2026
Copy link
Contributor

camc314 commented Feb 4, 2026

Merge activity

Follow-on after #18824. Refactor only.

Simplify building `@oxlint/plugins` package. Generate both the ESM and CommonJS builds in the same directory.
@graphite-app graphite-app bot force-pushed the om/02-03-build_oxlint_simplify_building_oxlint_plugins_ branch from 5367275 to e52005e Compare February 4, 2026 09:24
@graphite-app graphite-app bot merged commit e52005e into main Feb 4, 2026
19 checks passed
@graphite-app graphite-app bot deleted the om/02-03-build_oxlint_simplify_building_oxlint_plugins_ branch February 4, 2026 09:30
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants