Skip to content

build(linter/plugins): fix warning in build about Promise.allSettled #18823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Feb 2, 2026
Merged

build(linter/plugins): fix warning in build about Promise.allSettled #18823

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/oxlint/tsdown.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ const GLOBALS = new Set([

// Global properties which cannot be converted to top-level vars, because they're methods which use `this`.
// e.g. `const r = Promise.resolve; r(1);` throws "TypeError: PromiseResolve called on non-object".
const SKIP_GLOBALS = new Set(["Promise.resolve"]);
const SKIP_GLOBALS = new Set(["Promise.resolve", "Promise.allSettled"]);

/**
* Create a plugin to replace usage of properties of globals with global vars defined in `utils/globals.ts`.
Expand Down
Loading