Skip to content

build(linter/plugins): fix warning in build about Promise.allSettled#18823

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/02-02-build_linter_plugins_fix_warning_in_build_about_promise.allsettled_
Feb 2, 2026
Merged

build(linter/plugins): fix warning in build about Promise.allSettled#18823
graphite-app[bot] merged 1 commit intomainfrom
c/02-02-build_linter_plugins_fix_warning_in_build_about_promise.allsettled_

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Feb 2, 2026

No description provided.

Copy link
Contributor Author

camc314 commented Feb 2, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the TSDown “replace-globals” transform configuration to avoid attempting to convert Promise.allSettled into an imported global-var alias, eliminating the related build warning.

Changes:

  • Add Promise.allSettled to the SKIP_GLOBALS set of global properties that cannot safely be extracted due to this binding requirements.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@graphite-app graphite-app bot force-pushed the c/02-02-fix_linter_error_on_arrays_passed_in_as_config branch from 9c9362f to 64bed61 Compare February 2, 2026 00:40
@graphite-app graphite-app bot requested a review from overlookmotel as a code owner February 2, 2026 00:40
@graphite-app graphite-app bot force-pushed the c/02-02-build_linter_plugins_fix_warning_in_build_about_promise.allsettled_ branch from fad19b2 to ee17e03 Compare February 2, 2026 00:40
@graphite-app graphite-app bot changed the base branch from c/02-02-fix_linter_error_on_arrays_passed_in_as_config to graphite-base/18823 February 2, 2026 00:47
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 2, 2026

Merge activity

@graphite-app graphite-app bot changed the base branch from graphite-base/18823 to main February 2, 2026 00:53
@github-actions github-actions bot added the A-linter-plugins Area - Linter JS plugins label Feb 2, 2026
@graphite-app graphite-app bot force-pushed the c/02-02-build_linter_plugins_fix_warning_in_build_about_promise.allsettled_ branch from ee17e03 to fd07f3f Compare February 2, 2026 00:54
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Feb 2, 2026
@camc314 camc314 self-assigned this Feb 2, 2026
@graphite-app graphite-app bot merged commit fd07f3f into main Feb 2, 2026
19 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 2, 2026
@graphite-app graphite-app bot deleted the c/02-02-build_linter_plugins_fix_warning_in_build_about_promise.allsettled_ branch February 2, 2026 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter A-linter-plugins Area - Linter JS plugins

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants