test(oxlint/lsp): add lint tests on js side#18730
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
3b7910a to
3ed2edc
Compare
3b6131a to
ea64f40
Compare
3ed2edc to
de8276e
Compare
ea64f40 to
f78b41d
Compare
de8276e to
b692267
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds comprehensive LSP linting tests on the JavaScript/TypeScript side for the oxlint LSP server. It enhances the diagnostic formatting to include severity levels and adds test cases covering various configuration scenarios.
Changes:
- Enhanced diagnostic formatting in test utils to display severity levels (Error, Warning, Information, Hint)
- Added comprehensive test suite for LSP linting functionality with snapshot testing
- Created test fixtures covering default behavior, configuration options, and custom config paths
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| apps/oxlint/test/lsp/utils.ts | Added DiagnosticSeverity import and enhanced applyDiagnostics function to map and display severity levels in diagnostic output |
| apps/oxlint/test/lsp/lint/lint.test.ts | New test file with comprehensive test cases for LSP linting using snapshot testing, covering basic linting, config options, and initialization options |
| apps/oxlint/test/lsp/lint/fixtures/default/test.tsx | Test fixture file for TypeScript React linting with debugger statement |
| apps/oxlint/test/lsp/lint/fixtures/default/test.ts | Test fixture file for TypeScript linting with debugger statement |
| apps/oxlint/test/lsp/lint/fixtures/custom-config-path/test.ts | Test fixture file for custom config path testing |
| apps/oxlint/test/lsp/lint/fixtures/custom-config-path/lint.json | Custom config file setting no-debugger rule to error |
| apps/oxlint/test/lsp/lint/fixtures/config-severity/test.ts | Test fixture for severity configuration testing |
| apps/oxlint/test/lsp/lint/fixtures/config-severity/.oxlintrc.json | Config file setting no-debugger to error severity |
| apps/oxlint/test/lsp/lint/fixtures/config-disabled/test.ts | Test fixture for disabled rule testing |
| apps/oxlint/test/lsp/lint/fixtures/config-disabled/.oxlintrc.json | Config file disabling no-debugger rule |
| apps/oxlint/test/lsp/lint/fixtures/config-default/test.ts | Test fixture for default configuration |
| apps/oxlint/test/lsp/lint/fixtures/config-default/.oxlintrc.json | Empty default config file |
| apps/oxlint/test/lsp/lint/snapshots/lint.test.ts.snap | Snapshot file containing expected test outputs for all test cases |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b692267 to
38538a5
Compare
f78b41d to
52808d6
Compare
38538a5 to
4f3644f
Compare
52808d6 to
e4a7c67
Compare
4f3644f to
e908858
Compare
e4a7c67 to
6ed9b2a
Compare
e908858 to
a666e25
Compare
a666e25 to
ca16199
Compare
b55a4e0 to
f4579ef
Compare
9ce4531 to
5ecee3f
Compare
8654b7e to
e001415
Compare
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes
|
cd5a477 to
c0e4470
Compare
I can not explain why this error happens in CI (local without a problem) only with the JS Plugin configuration. This must be in the lint part of LSP-Server. The error message does not really explain much for me, :/ This is probably the return part of the diagnostic request, but I have no knowledge about the OS error :( |
2119759 to
74752d5
Compare
5ecee3f to
7fb0711
Compare
9b4ae47 to
f76df1b
Compare
Merge activity
|
7fb0711 to
c740e07
Compare
f76df1b to
7badd2b
Compare

No description provided.