Skip to content

test(oxlint/lsp): add init tests on js side#18729

Merged
graphite-app[bot] merged 1 commit intomainfrom
01-30-test_oxlint_lsp_add_init_tests_on_js_side
Feb 5, 2026
Merged

test(oxlint/lsp): add init tests on js side#18729
graphite-app[bot] merged 1 commit intomainfrom
01-30-test_oxlint_lsp_add_init_tests_on_js_side

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Jan 30, 2026

No description provided.

@github-actions github-actions bot added A-linter Area - Linter A-cli Area - CLI A-linter-plugins Area - Linter JS plugins C-test Category - Testing. Code is missing test cases, or a PR is adding them labels Jan 30, 2026
Copy link
Member Author

Sysix commented Jan 30, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sysix Sysix marked this pull request as ready for review January 30, 2026 12:28
@Sysix Sysix requested a review from camc314 as a code owner January 30, 2026 12:28
Copilot AI review requested due to automatic review settings January 30, 2026 12:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds JavaScript-side tests for LSP (Language Server Protocol) initialization functionality in the oxlint package. The changes introduce new test infrastructure to verify that the LSP server properly handles initialization requests, capabilities negotiation, and dynamic file watching registration.

Changes:

  • Added new test utilities for creating and interacting with LSP connections
  • Implemented initialization tests covering basic server startup, diagnostics provider configuration, and dynamic file watching patterns
  • Added required dependencies: @babel/code-frame, @types/babel__code-frame, and vscode-languageserver-protocol

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.

File Description
pnpm-lock.yaml Updated lockfile with new test dependencies (@babel/code-frame, @types/babel__code-frame, vscode-languageserver-protocol) and resolved debug package versions
apps/oxlint/package.json Added three new devDependencies for LSP testing infrastructure
apps/oxlint/test/lsp/utils.ts New utility module providing LSP connection helpers, fixture linting functions, and diagnostic formatting
apps/oxlint/test/lsp/init/init.test.ts New test file with three test cases validating LSP initialization behavior and dynamic registration
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Sysix Sysix force-pushed the 01-30-test_oxlint_lsp_add_init_tests_on_js_side branch 2 times, most recently from ea64f40 to f78b41d Compare January 30, 2026 12:33
@Sysix Sysix force-pushed the 01-30-test_oxlint_lsp_add_init_tests_on_js_side branch 3 times, most recently from e4a7c67 to 8c0e7f3 Compare January 30, 2026 17:20
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 30, 2026

Merging this PR will not alter performance

✅ 46 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing 01-30-test_oxlint_lsp_add_init_tests_on_js_side (5544c15) with main (005dd34)2

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (e71f563) during the generation of this report, so 005dd34 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@Sysix Sysix force-pushed the 01-30-test_oxlint_lsp_add_init_tests_on_js_side branch from 8c0e7f3 to 5544c15 Compare January 30, 2026 17:29
@github-actions github-actions bot added the A-editor Area - Editor and Language Server label Jan 30, 2026
@Sysix Sysix force-pushed the 01-30-test_oxlint_lsp_add_init_tests_on_js_side branch 4 times, most recently from 609e390 to fc32d5a Compare January 30, 2026 17:59
@Sysix Sysix marked this pull request as draft January 30, 2026 18:09
@Sysix Sysix force-pushed the 01-30-test_oxlint_lsp_add_init_tests_on_js_side branch from fc32d5a to b9819ab Compare January 30, 2026 19:15
@Sysix Sysix changed the base branch from main to graphite-base/18729 January 30, 2026 19:32
@Sysix Sysix force-pushed the 01-30-test_oxlint_lsp_add_init_tests_on_js_side branch from b9819ab to 3a2e7b2 Compare January 30, 2026 19:32
@Sysix Sysix changed the base branch from graphite-base/18729 to 01-30-fix_oxlint_lsp_use_tokio_block_in_place_for_detroying_workspaces January 30, 2026 19:32
@Sysix Sysix force-pushed the 01-30-test_oxlint_lsp_add_init_tests_on_js_side branch 2 times, most recently from 905f6c2 to 6344d21 Compare January 31, 2026 18:46
@Sysix Sysix removed the A-editor Area - Editor and Language Server label Jan 31, 2026
@Sysix Sysix force-pushed the 01-30-test_oxlint_lsp_add_init_tests_on_js_side branch 3 times, most recently from 6abc465 to d25a21f Compare February 1, 2026 14:48
@github-actions github-actions bot added the A-editor Area - Editor and Language Server label Feb 1, 2026
@Sysix Sysix force-pushed the 01-30-test_oxlint_lsp_add_init_tests_on_js_side branch 6 times, most recently from 1ee9670 to e900bad Compare February 2, 2026 17:59
@Sysix Sysix marked this pull request as ready for review February 2, 2026 18:45
@Sysix Sysix force-pushed the 01-30-test_oxlint_lsp_add_init_tests_on_js_side branch from e900bad to 9ce4531 Compare February 2, 2026 21:29
@camc314 camc314 closed this Feb 3, 2026
@camc314 camc314 reopened this Feb 3, 2026
@Sysix Sysix force-pushed the 01-30-test_oxlint_lsp_add_init_tests_on_js_side branch 2 times, most recently from 5ecee3f to 7fb0711 Compare February 5, 2026 16:41
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Feb 5, 2026
@graphite-app
Copy link
Contributor

graphite-app bot commented Feb 5, 2026

Merge activity

@graphite-app graphite-app bot force-pushed the 01-30-test_oxlint_lsp_add_init_tests_on_js_side branch from 7fb0711 to c740e07 Compare February 5, 2026 20:47
@graphite-app graphite-app bot merged commit c740e07 into main Feb 5, 2026
19 checks passed
@graphite-app graphite-app bot deleted the 01-30-test_oxlint_lsp_add_init_tests_on_js_side branch February 5, 2026 20:54
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-editor Area - Editor and Language Server A-linter Area - Linter A-linter-plugins Area - Linter JS plugins C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants