test(oxlint/lsp): add init tests on js side#18729
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Pull request overview
This PR adds JavaScript-side tests for LSP (Language Server Protocol) initialization functionality in the oxlint package. The changes introduce new test infrastructure to verify that the LSP server properly handles initialization requests, capabilities negotiation, and dynamic file watching registration.
Changes:
- Added new test utilities for creating and interacting with LSP connections
- Implemented initialization tests covering basic server startup, diagnostics provider configuration, and dynamic file watching patterns
- Added required dependencies:
@babel/code-frame,@types/babel__code-frame, andvscode-languageserver-protocol
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| pnpm-lock.yaml | Updated lockfile with new test dependencies (@babel/code-frame, @types/babel__code-frame, vscode-languageserver-protocol) and resolved debug package versions |
| apps/oxlint/package.json | Added three new devDependencies for LSP testing infrastructure |
| apps/oxlint/test/lsp/utils.ts | New utility module providing LSP connection helpers, fixture linting functions, and diagnostic formatting |
| apps/oxlint/test/lsp/init/init.test.ts | New test file with three test cases validating LSP initialization behavior and dynamic registration |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ea64f40 to
f78b41d
Compare
e4a7c67 to
8c0e7f3
Compare
Merging this PR will not alter performance
Comparing Footnotes
|
8c0e7f3 to
5544c15
Compare
609e390 to
fc32d5a
Compare
fc32d5a to
b9819ab
Compare
b9819ab to
3a2e7b2
Compare
905f6c2 to
6344d21
Compare
6abc465 to
d25a21f
Compare
1ee9670 to
e900bad
Compare
e900bad to
9ce4531
Compare
5ecee3f to
7fb0711
Compare
Merge activity
|
7fb0711 to
c740e07
Compare

No description provided.