refactor(linter): extract config searching functions to their own file#18673
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 29, 2026
Conversation
github-actions
bot
added
A-linter
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jan 28, 2026
camc314
force-pushed
the
c/01-28-refactor_linter_extract_config_searching_functions_to_their_own_file
branch
from
0b780a0 to
e11cb0f
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors oxlint’s config discovery by centralizing config file search logic in config_loader, and updating both CLI and LSP call sites to use the shared helpers.
Changes:
- Added shared config discovery helpers for ancestor-walk (CLI) and tree-walk (LSP) in
config_loader.rs. - Updated LSP nested-config discovery to use
discover_configs_in_tree. - Updated CLI nested-config discovery to use
discover_configs_in_ancestorsand improved the build-error message to include the config path.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/oxlint/src/lsp/server_linter.rs | Switches LSP nested config discovery to the shared tree-walk helper. |
| apps/oxlint/src/lint.rs | Replaces inline ancestor-walk config discovery with shared helper; improves config build error output. |
| apps/oxlint/src/config_loader.rs | Introduces shared config discovery functions (ancestor + tree) alongside existing config loading logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
camc314
force-pushed
the
c/01-28-refactor_linter_share_config_loading_logic_between_lsp_cli
branch
from
9392bdd to
fff2a9f
Compare
camc314
force-pushed
the
c/01-28-refactor_linter_extract_config_searching_functions_to_their_own_file
branch
from
e11cb0f to
1e332c9
Compare
graphite-app
bot
changed the base branch from
c/01-28-refactor_linter_share_config_loading_logic_between_lsp_cli
to
graphite-base/18673
graphite-app
bot
force-pushed
the
graphite-base/18673
branch
from
fff2a9f to
a88ed23
Compare
graphite-app
bot
force-pushed
the
c/01-28-refactor_linter_extract_config_searching_functions_to_their_own_file
branch
from
1e332c9 to
3089a77
Compare
graphite-app
bot
force-pushed
the
c/01-28-refactor_linter_extract_config_searching_functions_to_their_own_file
branch
from
3089a77 to
31aada2
Compare
Sysix
approved these changes
Jan 29, 2026
Contributor
Author
Merge activity
|
#18673) move the funcitons that search for config files out of sever_linter.rs/lint.rs into config_loader so that they're all in the same place
graphite-app
bot
force-pushed
the
c/01-28-refactor_linter_extract_config_searching_functions_to_their_own_file
branch
from
31aada2 to
5b11610
Compare
graphite-app
bot
deleted the
c/01-28-refactor_linter_extract_config_searching_functions_to_their_own_file
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
move the funcitons that search for config files out of sever_linter.rs/lint.rs into config_loader so that they're all in the same place