refactor(linter): share config loading logic between lsp/cli#18672
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 29, 2026
Merged
Conversation
github-actions
bot
added
A-linter
Contributor
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jan 28, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors oxlint configuration loading to centralize shared logic between the LSP and CLI paths.
Changes:
- Introduces a new
ConfigLoadermodule to parse/build configs and report errors uniformly. - Updates LSP nested-config discovery to use
ConfigLoader::load_many. - Updates CLI nested-config loading to use
ConfigLoader, simplifying config construction and error handling.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| apps/oxlint/src/lsp/server_linter.rs | Switches LSP nested config discovery/loading to the shared ConfigLoader. |
| apps/oxlint/src/lint.rs | Switches CLI nested config loading to the shared ConfigLoader and adjusts parameter types to slices. |
| apps/oxlint/src/lib.rs | Registers the new config_loader module. |
| apps/oxlint/src/config_loader.rs | Adds shared config loading implementation and error types. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
camc314
force-pushed
the
c/01-28-refactor_linter_share_config_loading_logic_between_lsp_cli
branch
from
9392bdd to
fff2a9f
Compare
Contributor
Author
Merge activity
|
these both do very similar things, this just helps align them to reduce some duplication with js config support.
graphite-app
bot
force-pushed
the
c/01-28-refactor_linter_share_config_loading_logic_between_lsp_cli
branch
from
fff2a9f to
a88ed23
Compare
graphite-app
bot
deleted the
c/01-28-refactor_linter_share_config_loading_logic_between_lsp_cli
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
these both do very similar things, this just helps align them to reduce some duplication with js config support.