Skip to content

refactor(linter/plugins): add type assertions to ensure correctness of TEST_CASE_PROP_KEYS_ARRAY #18450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Jan 23, 2026
+9 −2
Merged

refactor(linter/plugins): add type assertions to ensure correctness of TEST_CASE_PROP_KEYS_ARRAY #18450

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions apps/oxlint/src-js/package/rule_tester.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,8 @@ let sharedConfig: Config = {};

// List of keys that `ValidTestCase` or `InvalidTestCase` can have.
// Must be kept in sync with properties of `ValidTestCase` and `InvalidTestCase` interfaces.
const TEST_CASE_PROP_KEYS = new Set([
// The type constraints enforce this.
const TEST_CASE_PROP_KEYS_ARRAY = [
"code",
"name",
"only",
Expand All @@ -256,7 +257,13 @@ const TEST_CASE_PROP_KEYS = new Set([
"errors",
// Not a valid key for `TestCase` interface, but present here to prevent prototype pollution in `createConfigForRun`
"__proto__",
]);
] as const satisfies readonly (TestCaseOwnKeys | "__proto__")[];

type TestCaseOwnKeys = Exclude<keyof ValidTestCase | keyof InvalidTestCase, keyof Config>;
type MissingKeys = Exclude<TestCaseOwnKeys, (typeof TEST_CASE_PROP_KEYS_ARRAY)[number]>;
type KeysSet = MissingKeys extends never ? Set<string> : never;

const TEST_CASE_PROP_KEYS: KeysSet = new Set(TEST_CASE_PROP_KEYS_ARRAY);

/**
* Test case.
Expand Down
Loading