refactor(linter/plugins): add type assertions to ensure correctness of TEST_CASE_PROP_KEYS_ARRAY#18450
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 23, 2026
Conversation
github-actions
bot
added
A-linter
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds TypeScript type constraints to ensure that TEST_CASE_PROP_KEYS_ARRAY remains in sync with the TestCase interface properties. This prevents the mistake that was caught in PR #18445 where the settings field was added to the TestCase type but was forgotten in the keys array.
Changes:
- Renamed
TEST_CASE_PROP_KEYStoTEST_CASE_PROP_KEYS_ARRAYand added type constraints usingas const satisfies - Added helper types (
TestCaseOwnKeys,MissingKeys,KeysSet) that enforce completeness at compile time - The original
TEST_CASE_PROP_KEYSSet is now derived from the array with a type constraint that will cause a compile error if any keys are missing
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
Merge activity
|
…f `TEST_CASE_PROP_KEYS_ARRAY` (#18450) AI review on #18445 caught a mistake (#18445 (comment)). I'd neglected to add `"settings"` to `TEST_CASE_PROP_KEYS` when I added the field to the `TestCase` type. Add type constraints that prevent this mistake in future.
graphite-app
bot
force-pushed
the
om/01-23-feat_linter_plugins_ruletester_support_settings
branch
from
381f3ca to
b4b6247
Compare
graphite-app
bot
force-pushed
the
om/01-23-refactor_linter_plugins_add_type_assertions_to_ensure_correctness_of_test_case_prop_keys_array_
branch
from
8c0391b to
85903cd
Compare
Base automatically changed from
om/01-23-feat_linter_plugins_ruletester_support_settings
to
main
January 23, 2026 13:19
graphite-app
bot
deleted the
om/01-23-refactor_linter_plugins_add_type_assertions_to_ensure_correctness_of_test_case_prop_keys_array_
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI review on #18445 caught a mistake (#18445 (comment)). I'd neglected to add
"settings"toTEST_CASE_PROP_KEYSwhen I added the field to theTestCasetype.Add type constraints that prevent this mistake in future.