chore(oxfmt): Add comments for migrate overrides#18216
Merged
graphite-app[bot] merged 1 commit intomainfrom Jan 19, 2026
Merged
chore(oxfmt): Add comments for migrate overrides#18216graphite-app[bot] merged 1 commit intomainfrom
overrides#18216graphite-app[bot] merged 1 commit intomainfrom
Conversation
github-actions
bot
added
A-cli
leaysgur
changed the title
overrides
This was referenced Jan 19, 2026
Merged
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Dunqing
requested changes
Jan 19, 2026
Member
Dunqing
left a comment
Dunqing
left a comment
There was a problem hiding this comment.
Can we throw a warning with brief information and include the issue link?
graphite-app
bot
changed the base branch from
01-19-fix_oxfmt_apply_editorconfig_root_with_oxfmtrc.overrides
to
graphite-base/18216
graphite-app
bot
force-pushed
the
01-19-chore_oxfmt_add_comments_for_migrate_overrides
branch
from
eef144f to
f16abee
Compare
graphite-app
bot
force-pushed
the
graphite-base/18216
branch
from
15a5fcc to
63df94b
Compare
graphite-app
bot
force-pushed
the
01-19-chore_oxfmt_add_comments_for_migrate_overrides
branch
from
f16abee to
6e57199
Compare
graphite-app
bot
force-pushed
the
01-19-chore_oxfmt_add_comments_for_migrate_overrides
branch
from
6e57199 to
3aad578
Compare
graphite-app
bot
force-pushed
the
01-19-chore_oxfmt_add_comments_for_migrate_overrides
branch
from
3aad578 to
b35ef39
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #18215 by updating the Prettier migration logic to acknowledge that overrides configuration is now supported in Oxfmt but cannot be automatically migrated. The change removes the code that previously skipped overrides with an error message during config iteration, and adds a TODO comment with a warning explaining why automatic migration isn't possible.
Changes:
- Removed the conditional skip logic for
overridesduring Prettier config iteration - Added a TODO comment explaining the technical limitation (resolveConfig() doesn't include raw overrides)
- Added an unconditional warning message directing users to issue #18215 for more information
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Dunqing
approved these changes
Jan 19, 2026
Member
Merge activity
|
graphite-app
bot
force-pushed
the
01-19-chore_oxfmt_add_comments_for_migrate_overrides
branch
from
460baa6 to
6c4c4c0
Compare
graphite-app
bot
force-pushed
the
01-19-chore_oxfmt_add_comments_for_migrate_overrides
branch
from
6c4c4c0 to
a77294e
Compare
graphite-app
bot
force-pushed
the
01-19-chore_oxfmt_add_comments_for_migrate_overrides
branch
from
a77294e to
9a5e3e2
Compare
graphite-app
bot
deleted the
01-19-chore_oxfmt_add_comments_for_migrate_overrides
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please refer to #18215 for details.