Skip to content

fix(oxfmt): Apply .editorconfig root section with oxfmtrc.overrides#18210

Merged
graphite-app[bot] merged 1 commit intomainfrom
01-19-fix_oxfmt_apply_editorconfig_root_with_oxfmtrc.overrides
Jan 19, 2026
Merged

fix(oxfmt): Apply .editorconfig root section with oxfmtrc.overrides#18210
graphite-app[bot] merged 1 commit intomainfrom
01-19-fix_oxfmt_apply_editorconfig_root_with_oxfmtrc.overrides

Conversation

@leaysgur
Copy link
Member

@leaysgur leaysgur commented Jan 19, 2026

Fixed a bug found through self-review.

Copy link
Member Author

leaysgur commented Jan 19, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@leaysgur leaysgur changed the title fix(oxfmt): Apply editorconfig root with oxfmtrc.overrides fix(oxfmt): Apply .editorconfig root section with oxfmtrc.overrides Jan 19, 2026
@leaysgur leaysgur requested a review from Dunqing January 19, 2026 06:31
@leaysgur leaysgur force-pushed the 01-19-fix_oxfmt_apply_editorconfig_root_with_oxfmtrc.overrides branch from 06edea0 to 15a5fcc Compare January 19, 2026 06:32
@Dunqing
Copy link
Member

Dunqing commented Jan 19, 2026

Do we need documentation for configuration priorities?

@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Jan 19, 2026
Copy link
Member

Dunqing commented Jan 19, 2026

Merge activity

  • Jan 19, 7:39 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 19, 7:39 AM UTC: Dunqing added this pull request to the Graphite merge queue.
  • Jan 19, 9:17 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Jan 19, 9:17 AM UTC: Dunqing added this pull request to the Graphite merge queue.
  • Jan 19, 9:24 AM UTC: Merged by the Graphite merge queue.

@graphite-app graphite-app bot force-pushed the 01-19-test_oxfmt_test_oxfmtrc.overrides branch from 3b855a7 to 63df94b Compare January 19, 2026 07:40
graphite-app bot pushed a commit that referenced this pull request Jan 19, 2026
@graphite-app graphite-app bot force-pushed the 01-19-fix_oxfmt_apply_editorconfig_root_with_oxfmtrc.overrides branch from 15a5fcc to 6f37722 Compare January 19, 2026 07:40
Base automatically changed from 01-19-test_oxfmt_test_oxfmtrc.overrides to main January 19, 2026 07:47
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 19, 2026
@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Jan 19, 2026
Copilot AI review requested due to automatic review settings January 19, 2026 09:17
@graphite-app graphite-app bot force-pushed the 01-19-fix_oxfmt_apply_editorconfig_root_with_oxfmtrc.overrides branch from 6f37722 to 73fedb9 Compare January 19, 2026 09:18
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@graphite-app graphite-app bot merged commit 73fedb9 into main Jan 19, 2026
19 checks passed
@graphite-app graphite-app bot deleted the 01-19-fix_oxfmt_apply_editorconfig_root_with_oxfmtrc.overrides branch January 19, 2026 09:24
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 19, 2026
@leaysgur
Copy link
Member Author

Thanks!

I was planning to update the documentation along with the other updates for the 0.25 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-formatter Area - Formatter C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants