fix(parser): respect optional TSNamedTupleMember for ts error 1266 &1257

[Sysix]

This PR fixes TypeScript parser errors 1266 and 1257 by properly handling the optional field of TSNamedTupleMember when validating tuple element ordering constraints.

Introduced in #18146 and #18145

[Sysix]

• fix(parser): respect optional TSNamedTupleMember for ts error 1266 &1257 #18178 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging this PR will not alter performance

_{Comparing 01-18-fix_parser_respect_optional_tsnamedtuplemember_for_ts_error_1266_1257 (2c76cdf) with main (175b73a)}

Summary

✅ 42 untouched benchmarks
⏩ 3 skipped benchmarks¹

Footnotes

1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Copilot]

Pull request overview

This PR fixes TypeScript parser errors 1266 and 1257 by properly handling the optional field of TSNamedTupleMember when validating tuple element ordering constraints.

Changes:

• Updated tuple type parsing logic to respect the optional field on TSNamedTupleMember when checking element ordering
• Added test case for multiple consecutive optional named tuple members
• Updated test snapshots to reflect the new test case and corrected babel test behavior

Reviewed changes

Copilot reviewed 1 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
crates/oxc_parser/src/ts/types.rs	Extended tuple element validation to check TSNamedTupleMember.optional field alongside TSOptionalType when enforcing ordering constraints
tasks/coverage/misc/pass/ts-tuple-named-optional-member-twice.ts	New test case for two consecutive optional named tuple members
tasks/coverage/snapshots/parser_misc.snap	Updated to reflect new test case (62/62 tests)
tasks/coverage/snapshots/transformer_misc.snap	Updated to reflect new test case (62/62 tests)
tasks/coverage/snapshots/semantic_misc.snap	Updated to reflect new test case (62/62 tests)
tasks/coverage/snapshots/formatter_misc.snap	Updated to reflect new test case (62/62 tests)
tasks/coverage/snapshots/codegen_misc.snap	Updated to reflect new test case (62/62 tests)
tasks/coverage/snapshots/parser_babel.snap	Reflects that tuple-required-after-labeled-optional test now correctly produces TS(1257) error instead of parse error

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Boshen]

Merge activity

• Jan 18, 11:35 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Jan 18, 11:35 AM UTC: Boshen added this pull request to the Graphite merge queue.
• Jan 18, 11:41 AM UTC: Merged by the Graphite merge queue.