Skip to content

feat(parser): add ts error 1257 for TSTupleElement#18146

Merged
graphite-app[bot] merged 1 commit intomainfrom
01-17-feat_parser_add_ts_error_1257_for_tstupleelement_
Jan 18, 2026
Merged

feat(parser): add ts error 1257 for TSTupleElement#18146
graphite-app[bot] merged 1 commit intomainfrom
01-17-feat_parser_add_ts_error_1257_for_tstupleelement_

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented Jan 17, 2026

No description provided.

@github-actions github-actions bot added A-parser Area - Parser C-enhancement Category - New feature or request labels Jan 17, 2026
@Sysix Sysix mentioned this pull request Jan 17, 2026
Merged
@Sysix Graphite App
Copy link
Member Author

Sysix commented Jan 17, 2026 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sysix Sysix mentioned this pull request Jan 17, 2026
Merged
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 17, 2026 •
edited
Loading

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing 01-17-feat_parser_add_ts_error_1257_for_tstupleelement_ (5e2b0a6) with 01-17-feat_parser_add_ts_error_1266_for_tstupleelement_ (d8312a5)

Summary

✅ 42 untouched benchmarks
⏩ 3 skipped benchmarks1

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@Sysix Sysix marked this pull request as ready for review January 17, 2026 21:09
@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label Jan 18, 2026
@Boshen Graphite App
Copy link
Member

Boshen commented Jan 18, 2026 •
edited by graphite-app bot
Loading

Merge activity

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 18, 2026
@Sysix Sysix force-pushed the 01-17-feat_parser_add_ts_error_1266_for_tstupleelement_ branch from a62c954 to d8312a5 Compare January 18, 2026 10:18
@Sysix Sysix force-pushed the 01-17-feat_parser_add_ts_error_1257_for_tstupleelement_ branch from cf38be1 to 5e2b0a6 Compare January 18, 2026 10:18
@Sysix Sysix added the 0-merge Merge with Graphite Merge Queue label Jan 18, 2026
@graphite-app graphite-app bot force-pushed the 01-17-feat_parser_add_ts_error_1266_for_tstupleelement_ branch 2 times, most recently from 46cf399 to 373c4e2 Compare January 18, 2026 10:34
@graphite-app graphite-app bot force-pushed the 01-17-feat_parser_add_ts_error_1257_for_tstupleelement_ branch from 5e2b0a6 to 671c8a4 Compare January 18, 2026 10:34
@graphite-app graphite-app bot force-pushed the 01-17-feat_parser_add_ts_error_1266_for_tstupleelement_ branch from 373c4e2 to fa2ffe2 Compare January 18, 2026 10:40
@graphite-app graphite-app bot force-pushed the 01-17-feat_parser_add_ts_error_1257_for_tstupleelement_ branch from 671c8a4 to 175b73a Compare January 18, 2026 10:40
Base automatically changed from 01-17-feat_parser_add_ts_error_1266_for_tstupleelement_ to main January 18, 2026 10:46
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 18, 2026
@graphite-app graphite-app bot merged commit 175b73a into main Jan 18, 2026
23 checks passed
@graphite-app graphite-app bot deleted the 01-17-feat_parser_add_ts_error_1257_for_tstupleelement_ branch January 18, 2026 10:47
@Sysix Sysix mentioned this pull request Jan 18, 2026
Merged
graphite-app bot pushed a commit that referenced this pull request Jan 18, 2026
@Sysix
fix(parser): respect optional TSNamedTupleMember for ts error 1266 …
37482eb 
…&1257 (#18178)

> This PR fixes TypeScript parser errors 1266 and 1257 by properly handling the `optional` field of `TSNamedTupleMember` when validating tuple element ordering constraints.

Introduced in #18146 and #18145
@Boshen Boshen mentioned this pull request Jan 19, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-parser Area - Parser C-enhancement Category - New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Sysix @Boshen