perf(transformer/typescript): reduce scope_id() calls

[overlookmotel]

Tiny optimization. Calling EnumBody::scope_id has a cost (a panicking branch). We already called it earlier in this function and have the scope ID in a local var. Use that value, rather then calling scope_id() again.

[overlookmotel]

• perf(transformer/typescript): reduce scope_id() calls #18097 👈 (View in Graphite)
• refactor(semantic): remove unnecessary code #18096
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

Merging this PR will not alter performance

✅ 38 untouched benchmarks
⏩ 7 skipped benchmarks¹

---

_{Comparing om/01-16-perf_transformer_typescript_reduce_scope_id_calls (d1fa554) with main (08dad63)²}

Footnotes

1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

2. No successful run was found on om/01-16-refactor_semantic_remove_unnecessary_code (8e94bb7) during the generation of this report, so main (08dad63) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[Copilot]

Pull request overview

This PR implements a micro-optimization in the TypeScript enum transformation code by eliminating a redundant method call. The scope_id() method has a cost (including a panicking branch), and since the scope ID was already retrieved and stored in a local variable earlier in the function, the code now reuses that cached value instead of making the same call again.

Changes:

• Replace redundant decl.body.scope_id() call with the existing func_scope_id variable

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[overlookmotel]

Merge activity

• Jan 16, 4:53 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Jan 16, 4:53 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
• Jan 16, 5:01 PM UTC: Merged by the Graphite merge queue.