refactor(semantic): remove unnecessary code

[overlookmotel]

Follow-on after #18058. visit_ts_enum_body method added to SemanticBuilder in that PR is unnecessary, as it's identical to the default implementation provided by Visit trait. Remove it.

[overlookmotel]

• perf(transformer/typescript): reduce scope_id() calls #18097
• refactor(semantic): remove unnecessary code #18096 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull request overview

This PR removes a custom visit_ts_enum_body implementation from SemanticBuilder to rely on the default implementation from the Visit trait. The PR description states the custom implementation is identical to the default, but this is actually a bug fix as the removed custom implementation was missing a visit_span call that the default implementation includes.

Changes:

• Removed custom visit_ts_enum_body method from SemanticBuilder in builder.rs

Comments suppressed due to low confidence (1)

crates/oxc_semantic/src/builder.rs:1

• The removed custom implementation was missing a visit_span(&body.span) call that exists in the default walk_ts_enum_body implementation. While removing this code is correct (allowing the default implementation to be used), the PR description is misleading as it states the implementations are 'identical' when in fact the custom implementation had a bug (missing span visit). The removal is actually a bug fix, not just removal of unnecessary code. Consider updating the PR description to clarify this is fixing a missing span visit rather than just removing duplicate code.

//! Semantic Builder

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codspeed-hq]

CodSpeed Performance Report

Merging this PR will not alter performance

_{Comparing om/01-16-refactor_semantic_remove_unnecessary_code (8e94bb7) with main (08dad63)}

Summary

✅ 42 untouched benchmarks
⏩ 3 skipped benchmarks¹

Footnotes

1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[graphite-app]

Merge activity

• Jan 16, 4:53 PM UTC: overlookmotel added this pull request to the Graphite merge queue.
• Jan 16, 5:00 PM UTC: Merged by the Graphite merge queue.