Skip to content

refactor(transformer/tagged-template): reorder functions#18032

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/01-15-refactor_transformer_tagged-template_reorder_functions
Jan 15, 2026
Merged

refactor(transformer/tagged-template): reorder functions#18032
graphite-app[bot] merged 1 commit intomainfrom
om/01-15-refactor_transformer_tagged-template_reorder_functions

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jan 15, 2026

Follow-on after #15834. Pure refactor. Re-order functions so the main entry to the transform is at the top.

Also add a debug_assert!.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jan 15, 2026
Copy link
Member Author

overlookmotel commented Jan 15, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 15, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing om/01-15-refactor_transformer_tagged-template_reorder_functions (4aede96) with om/01-15-refactor_transformer_tagged-template_rename_var (5c32920)

Summary

✅ 38 untouched benchmarks
⏩ 7 skipped benchmarks1

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the tagged_template_transform.rs file by reordering functions to place the main entry point at the top of the implementation. The transform_tagged_template method is moved from its position after helper functions to immediately after the constructor, improving code readability and organization.

Changes:

  • Moved transform_tagged_template method to be the first method after the constructor
  • Added a period to the doc comment for consistency
  • Added a debug_assert! to verify the expression type precondition

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Jan 15, 2026
@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 15, 2026

Merge activity

Follow-on after #15834. Pure refactor. Re-order functions so the main entry to the transform is at the top.

Also add a `debug_assert!`.
@graphite-app graphite-app bot force-pushed the om/01-15-refactor_transformer_tagged-template_rename_var branch from 5c32920 to b332934 Compare January 15, 2026 13:46
@graphite-app graphite-app bot force-pushed the om/01-15-refactor_transformer_tagged-template_reorder_functions branch from 4aede96 to b02ad91 Compare January 15, 2026 13:47
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 15, 2026
Base automatically changed from om/01-15-refactor_transformer_tagged-template_rename_var to main January 15, 2026 13:53
@graphite-app graphite-app bot merged commit b02ad91 into main Jan 15, 2026
22 checks passed
@graphite-app graphite-app bot deleted the om/01-15-refactor_transformer_tagged-template_reorder_functions branch January 15, 2026 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants