Skip to content

refactor(transformer/tagged-template): merge functions#18030

Merged
graphite-app[bot] merged 1 commit intomainfrom
om/01-15-refactor_transformer_tagged-template_merge_functions
Jan 15, 2026
Merged

refactor(transformer/tagged-template): merge functions#18030
graphite-app[bot] merged 1 commit intomainfrom
om/01-15-refactor_transformer_tagged-template_merge_functions

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Jan 15, 2026

Follow-on after #15834. Pure refactor. Merge 2 small functions. The separation was only required previously due to inlining transform_tagged_template, but we don't do that any more.

@github-actions github-actions bot added A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Jan 15, 2026
Copy link
Member Author

overlookmotel commented Jan 15, 2026


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the tagged template transform by merging two small functions into one. The transform_tagged_template_impl function has been inlined into transform_tagged_template, simplifying the code structure without changing behavior.

Changes:

  • Merged transform_tagged_template_impl into transform_tagged_template

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 15, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing om/01-15-refactor_transformer_tagged-template_merge_functions (40fa539) with main (23449e0)

Summary

✅ 38 untouched benchmarks
⏩ 7 skipped benchmarks1

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Jan 15, 2026
@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 15, 2026

Merge activity

Follow-on after #15834. Pure refactor. Merge 2 small functions. The separation was only required previously due to inlining `transform_tagged_template`, but we don't do that any more.
@graphite-app graphite-app bot force-pushed the om/01-15-refactor_transformer_tagged-template_merge_functions branch from 40fa539 to 651abb9 Compare January 15, 2026 13:45
@graphite-app graphite-app bot merged commit 651abb9 into main Jan 15, 2026
21 checks passed
@graphite-app graphite-app bot deleted the om/01-15-refactor_transformer_tagged-template_merge_functions branch January 15, 2026 13:52
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants