perf(linter): inline is_function_node into run functions

[camchenry]

Inlining the is_function_node function allows the linter codegen to do the static analysis more easily. I suppose this is slightly negative towards less maintainability, but I don't expect we'll have more types of functions added to JS anytime soon. And the +1-2% improvement is hard to pass up for being so easy:

[camchenry]

• perf(linter/only-used-in-recursion): improve skip_to_next_char slicing #17374
• perf(linter): inline is_function_node into run functions #17373 👈 (View in Graphite)
• perf(linter): no-multi-str: skip searching strings when in jsx attribute #17327
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #17373 will not alter performance

_{Comparing 12-24-perf_linter_inline_is_function_node_into_run_functions (23857c2) with main (445ff9e)}

Summary

✅ 4 untouched
⏩ 41 skipped¹

Footnotes

1. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Copilot]

Pull request overview

This PR aims to improve linter performance by 1-2% by inlining the is_function_node helper function directly into the run methods of two rules, allowing the linter codegen to perform better static analysis and optimize node type filtering.

Key changes:

• Inlined function node type checks in max_nested_callbacks and max_lines_per_function rules
• Updated generated code to specify NODE_TYPES bitsets for more efficient node filtering
• Removed is_function_node import from the affected rules

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File	Description
crates/oxc_linter/src/rules/eslint/max_nested_callbacks.rs	Inlined function node checks at the start of run() and removed is_function_node check from is_callback() helper
crates/oxc_linter/src/rules/eslint/max_lines_per_function.rs	Inlined function node checks at the start of run() and removed is_function_node import
crates/oxc_linter/src/generated/rule_runner_impls.rs	Updated NODE_TYPES to filter for Function and ArrowFunctionExpression types

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[camc314]

Merge activity

• Dec 27, 11:48 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Dec 27, 11:51 AM UTC: camc314 added this pull request to the Graphite merge queue.
• Dec 27, 11:57 AM UTC: Merged by the Graphite merge queue.