perf(linter): no-multi-str: skip searching strings when in jsx attribute

[camchenry]

Optimization for JSX files: we can skip looking at string literals right away if it's inside of a JSX attribute, instead of searching the whole value first.

[camchenry]

• perf(linter/only-used-in-recursion): improve skip_to_next_char slicing #17374
• perf(linter): inline is_function_node into run functions #17373
• perf(linter): no-multi-str: skip searching strings when in jsx attribute #17327 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #17327 will not alter performance

_{Comparing 12-23-perf_linter_no-multi-str_skip_searching_strings_when_in_jsx_attribute (120c867) with main (3ed6d94)}

Summary

✅ 4 untouched
⏩ 41 skipped¹

Footnotes

1. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Copilot]

Pull request overview

This PR optimizes the no-multi-str linter rule for JSX files by performing an early check for JSX attributes before searching string contents for multiline patterns. This avoids unnecessary string scanning operations when the string is inside a JSX attribute (where multiline strings are allowed).

Key Changes:

• Early return when string literal is within a JSX attribute, avoiding expensive string search
• Refactored string search logic to use idiomatic Option handling instead of unwrap_or(0) pattern
• Inlined and removed the is_within_jsx_attribute helper function

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[camc314]

Merge activity

• Dec 26, 4:32 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Dec 26, 4:32 PM UTC: camc314 added this pull request to the Graphite merge queue.
• Dec 26, 4:38 PM UTC: Merged by the Graphite merge queue.