refactor(oxfmt): load_ignore_paths() also checks existence#17351
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 25, 2025
Merged
Conversation
github-actions
bot
added
A-cli
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the load_ignore_paths function to centralize file existence validation by moving the check from the caller into the function itself.
- Changed
load_ignore_pathsreturn type fromVec<PathBuf>toResult<Vec<PathBuf>, String>to handle validation errors - Moved existence check for explicitly provided ignore paths into
load_ignore_pathsfunction - Added clarifying comments to distinguish between mandatory explicitly-provided ignore paths and optional default ignore files
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
leaysgur
changed the title
load_ignore_paths() also checks existence
Contributor
Merge activity
|
Pure refactoring.
graphite-app
bot
force-pushed
the
12-25-refactor_oxfmt_load_ignore_paths_also_checks_existence
branch
from
1badd71 to
30e5873
Compare
graphite-app
bot
deleted the
12-25-refactor_oxfmt_load_ignore_paths_also_checks_existence
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure refactoring.