feat(formatter): normalize line break for directive

[Dunqing]

Fixes panic caused by

oxc/crates/oxc_formatter/src/formatter/builders.rs

Lines 336 to 348 in 88a38b2

	/// Debug assert that the given text contains no `\r` line terminator characters.
	//
	// `#[inline(always)]` because this is a no-op in release mode
	#[inline(always)]
	#[expect(clippy::inline_always)]
	#[track_caller]
	fn debug_assert_no_cr_line_break(text: &str) {
	debug_assert!(
	!text.contains('\r'),
	"The content `{text}` contains an unsupported `\\r` line terminator character but text must only use line feeds `\\n` as line separator. Use `\\n` instead of `\\r` and `\\r\\n` to insert a line break in strings."
	);
	}

in #17261

[Dunqing]

• test(formatter): run conformance tests with different options #17261
• feat(formatter): normalize line break for directive #17303 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull request overview

This PR adds line break normalization for directive strings in the formatter. The main changes normalize carriage return characters (\r) to newlines (\n) in directive strings while preserving the directive's quote style and escape sequences.

Key changes:

• Fixes typo in comment: "diretcives" → "directives"
• Removes #[expect(unused)] attribute from normalize_newlines function (now being used)
• Updates normalize_directive to call normalize_newlines on directive content and handle both borrowed and owned results

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
crates/oxc_formatter/src/formatter/format_element/mod.rs	Removes unused warning attribute since normalize_newlines is now actively used
crates/oxc_formatter/src/utils/string.rs	Fixes typo and adds newline normalization logic to normalize_directive method

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codspeed-hq]

CodSpeed Performance Report

Merging #17303 will not alter performance

_{Comparing 12-23-feat_formatter_normalize_line_break_for_directive (bbb5a43) with main (c813582)¹}

Summary

✅ 38 untouched
⏩ 7 skipped²

Footnotes

1. No successful run was found on main (c6690d1) during the generation of this report, so c813582 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

2. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[graphite-app]

Merge activity

• Dec 24, 1:04 AM UTC: leaysgur added this pull request to the Graphite merge queue.
• Dec 24, 1:11 AM UTC: Merged by the Graphite merge queue.