Skip to content

test(formatter): run conformance tests with different options#17261

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-22-test_formatter_run_conformance_tests_with_different_options
Dec 24, 2025
Merged

test(formatter): run conformance tests with different options#17261
graphite-app[bot] merged 1 commit intomainfrom
12-22-test_formatter_run_conformance_tests_with_different_options

Conversation

@Dunqing
Copy link
Member

@Dunqing Dunqing commented Dec 22, 2025

Context: #17151 (comment)

We have to run conformance tests with different options from the defaults, especially those options (semicolon, quote props) that can cause a syntax error if there is a bug

@github-actions github-actions bot added the C-test Category - Testing. Code is missing test cases, or a PR is adding them label Dec 22, 2025
Copy link
Member Author

Dunqing commented Dec 22, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Dunqing Dunqing changed the base branch from main to graphite-base/17261 December 23, 2025 08:43
@Dunqing Dunqing force-pushed the 12-22-test_formatter_run_conformance_tests_with_different_options branch from f1b2fa9 to 88a38b2 Compare December 23, 2025 08:44
@Dunqing Dunqing changed the base branch from graphite-base/17261 to 12-23-feat_formatter_normalize_line_break_for_directive December 23, 2025 08:44
@Dunqing Dunqing marked this pull request as ready for review December 23, 2025 08:59
@Dunqing Dunqing requested a review from leaysgur December 23, 2025 09:26
Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👍

@Dunqing Dunqing force-pushed the 12-23-feat_formatter_normalize_line_break_for_directive branch from 4f1fcf9 to bbb5a43 Compare December 23, 2025 14:16
@Dunqing Dunqing force-pushed the 12-22-test_formatter_run_conformance_tests_with_different_options branch from 88a38b2 to 5a6e253 Compare December 23, 2025 14:16
Copy link
Member

@leaysgur leaysgur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, let's merge first.

@leaysgur leaysgur added the 0-merge Merge with Graphite Merge Queue label Dec 24, 2025
Copy link
Member

leaysgur commented Dec 24, 2025

Merge activity

@graphite-app graphite-app bot changed the base branch from 12-23-feat_formatter_normalize_line_break_for_directive to graphite-base/17261 December 24, 2025 01:05
@graphite-app graphite-app bot force-pushed the graphite-base/17261 branch from bbb5a43 to b00da37 Compare December 24, 2025 01:12
@graphite-app graphite-app bot force-pushed the 12-22-test_formatter_run_conformance_tests_with_different_options branch from 5a6e253 to 3fcdb4a Compare December 24, 2025 01:12
@graphite-app graphite-app bot changed the base branch from graphite-base/17261 to main December 24, 2025 01:12
@graphite-app graphite-app bot force-pushed the 12-22-test_formatter_run_conformance_tests_with_different_options branch from 3fcdb4a to 4484818 Compare December 24, 2025 01:13
Context: #17151 (comment)

We have to run conformance tests with different options from the defaults, especially those options (semicolon, quote props) that can cause a syntax error if there is a bug
@graphite-app graphite-app bot force-pushed the 12-22-test_formatter_run_conformance_tests_with_different_options branch from 4484818 to a7d4878 Compare December 24, 2025 01:20
@graphite-app graphite-app bot merged commit a7d4878 into main Dec 24, 2025
18 checks passed
@graphite-app graphite-app bot deleted the 12-22-test_formatter_run_conformance_tests_with_different_options branch December 24, 2025 01:26
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-test Category - Testing. Code is missing test cases, or a PR is adding them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants