Skip to content

fix(linter/import-first): correctly respect all relative path imports #17268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camc314 merged 2 commits into from
Dec 22, 2025
Merged

fix(linter/import-first): correctly respect all relative path imports #17268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
933b0a5
feat(linter): Update is_relative_path to include other relative patterns
mohitk05 Dec 22, 2025
88a12a5
Merge branch 'main' into 17020-fix-import-first
camc314 Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion crates/oxc_linter/src/rules/import/first.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,9 @@ declare_oxc_lint!(
);

fn is_relative_path(path: &str) -> bool {
path.starts_with("./")
// A path is considered relative if it starts with "/", "./", or "../"
// https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import#module_specifier_resolution
path.starts_with("./") || path.starts_with("../") || path.starts_with('/')
}

/// <https://github.com/import-js/eslint-plugin-import/blob/v2.29.1/docs/rules/first.md>
Expand Down Expand Up @@ -169,6 +171,17 @@ fn test() {
export { x, y }",
None,
),
// Relative imports with absolute-first
(
r"import { y } from 'bar';
import { x } from '../foo';",
Some(json!(["absolute-first"])),
),
(
r"import { y } from 'bar';
import { x } from '/foo';",
Some(json!(["absolute-first"])),
),
];

let fail = vec![
Expand Down Expand Up @@ -208,6 +221,17 @@ fn test() {
import F3 = require('mod');",
None,
),
// Relative imports with absolute-first
(
r"import { x } from '../foo';
import { y } from 'bar';",
Some(json!(["absolute-first"])),
),
(
r"import { x } from '/foo';
import { y } from 'bar';",
Some(json!(["absolute-first"])),
),
];

Tester::new(First::NAME, First::PLUGIN, pass, fail)
Expand Down
16 changes: 16 additions & 0 deletions crates/oxc_linter/src/snapshots/import_first.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,3 +81,19 @@ source: crates/oxc_linter/src/tester.rs
· ───────────────────────────
╰────
help: Move import statement to the top of the file

⚠ eslint-plugin-import(first): Relative imports before absolute imports are prohibited
╭─[index.ts:2:33]
1 │ import { x } from '../foo';
2 │ import { y } from 'bar';
· ─────
╰────
help: Move absolute import above relative import

⚠ eslint-plugin-import(first): Relative imports before absolute imports are prohibited
╭─[index.ts:2:33]
1 │ import { x } from '/foo';
2 │ import { y } from 'bar';
· ─────
╰────
help: Move absolute import above relative import
Loading