Skip to content

fix(linter/import-first): correctly respect all relative path imports#17268

Merged
camc314 merged 2 commits intooxc-project:mainfrom
mohitk05:17020-fix-import-first
Dec 22, 2025
Merged

fix(linter/import-first): correctly respect all relative path imports#17268
camc314 merged 2 commits intooxc-project:mainfrom
mohitk05:17020-fix-import-first

Conversation

@mohitk05
Copy link
Contributor

Closes: #17020

Update path pattern check for is_relative_import in import/first eslint rule and add supporting tests.

@mohitk05 mohitk05 requested a review from camc314 as a code owner December 22, 2025 12:21
@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Dec 22, 2025
Copy link
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank yoU!

@camc314 camc314 changed the title feat(linter): Update is_relative_path in import/first to include other relative path patterns fix(linter/import-first): correctly respect all relative path imports Dec 22, 2025
@camc314 camc314 self-assigned this Dec 22, 2025
@github-actions github-actions bot added the C-bug Category - Bug label Dec 22, 2025
@camc314 camc314 merged commit b547335 into oxc-project:main Dec 22, 2025
19 checks passed
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 22, 2025

CodSpeed Performance Report

Merging #17268 will not alter performance

Comparing mohitk05:17020-fix-import-first (88a12a5) with main (4ac23e1)

Summary

✅ 4 untouched
⏩ 41 skipped1

Footnotes

  1. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-bug Category - Bug C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Linter: not all relative paths identified in import/first rule?

2 participants