Skip to content

fix(ast_tools): visit nested objects to add __proto__: NodeProto in raw transfer codegen #17230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Dec 21, 2025
Merged

fix(ast_tools): visit nested objects to add __proto__: NodeProto in raw transfer codegen #17230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 15 additions & 14 deletions tasks/ast_tools/src/generators/raw_transfer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ use oxc_ast::{
Expression, LogicalOperator, ObjectExpression, ObjectPropertyKind, Program, PropertyKind,
},
};
use oxc_ast_visit::VisitMut;
use oxc_ast_visit::{VisitMut, walk_mut};
use oxc_span::SPAN;

use crate::{
Expand Down Expand Up @@ -1410,20 +1410,21 @@ impl<'a> VisitMut<'a> for LocFieldAdder<'a> {
false
}
});
if !has_range_field {
return;

if has_range_field {
// Insert `__proto__: NodeProto` as first field
let prop = self.ast.object_property_kind_object_property(
SPAN,
PropertyKind::Init,
self.ast.property_key_static_identifier(SPAN, "__proto__"),
self.ast.expression_identifier(SPAN, "NodeProto"),
false,
false,
false,
);
obj_expr.properties.insert(0, prop);
}

// Insert `__proto__: NodeProto` as first field
let prop = self.ast.object_property_kind_object_property(
SPAN,
PropertyKind::Init,
self.ast.property_key_static_identifier(SPAN, "__proto__"),
self.ast.expression_identifier(SPAN, "NodeProto"),
false,
false,
false,
);
obj_expr.properties.insert(0, prop);
walk_mut::walk_object_expression(self, obj_expr);
}
}
Loading