fix(ast_tools): visit nested objects to add __proto__: NodeProto in raw transfer codegen#17230
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 21, 2025
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Dec 21, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the ESTree walker codegen where nested objects were not being visited when adding __proto__: NodeProto to node objects. The fix ensures that all object expressions (including nested ones) with a range field will receive the __proto__ property.
- Refactored the conditional logic to use a positive condition instead of early return
- Added
walk_mut::walk_object_expressioncall to recursively visit nested object expressions - Imported
walk_mutfromoxc_ast_visitto enable the recursive walking functionality
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
overlookmotel
force-pushed
the
om/12-21-fix_ast_tools_visit_nested_objects_to_add___proto___nodeproto_in_raw_transfer_codegen
branch
from
d760626 to
be97ee1
Compare
overlookmotel
force-pushed
the
om/12-20-feat_linter_plugins_implement_code_path_analysis_cfg_
branch
from
6427333 to
cc6d0cf
Compare
Contributor
Merge activity
|
graphite-app
bot
force-pushed
the
om/12-20-feat_linter_plugins_implement_code_path_analysis_cfg_
branch
from
cc6d0cf to
d913f87
Compare
graphite-app
bot
force-pushed
the
om/12-21-fix_ast_tools_visit_nested_objects_to_add___proto___nodeproto_in_raw_transfer_codegen
branch
from
be97ee1 to
3d264cb
Compare
Base automatically changed from
om/12-20-feat_linter_plugins_implement_code_path_analysis_cfg_
to
main
December 21, 2025 21:00
graphite-app
bot
deleted the
om/12-21-fix_ast_tools_visit_nested_objects_to_add___proto___nodeproto_in_raw_transfer_codegen
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a bug in codegen for ESTree walker, where it didn't visit nested objects when it adds
__proto__: NodePrototo node objects. This doesn't make any difference now, but fixing it is required for next PR (#17231).