Skip to content

perf(linter/curly): remove iterating on all nodes#17223

Merged
graphite-app[bot] merged 1 commit intomainfrom
c/12-21-perf_linter_curly_remove_iterating_on_all_nodes
Dec 21, 2025
Merged

perf(linter/curly): remove iterating on all nodes#17223
graphite-app[bot] merged 1 commit intomainfrom
c/12-21-perf_linter_curly_remove_iterating_on_all_nodes

Conversation

@camc314
Copy link
Contributor

@camc314 camc314 commented Dec 21, 2025

fixes #17221

@github-actions github-actions bot added A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance labels Dec 21, 2025
Copy link
Contributor Author

camc314 commented Dec 21, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@camc314 camc314 marked this pull request as ready for review December 21, 2025 17:49
@camc314 camc314 self-assigned this Dec 21, 2025
@camc314 camc314 force-pushed the c/12-21-perf_linter_curly_remove_iterating_on_all_nodes branch from b30831c to 1d5fe56 Compare December 21, 2025 17:51
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label Dec 21, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 21, 2025

Merge activity

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 21, 2025

CodSpeed Performance Report

Merging #17223 will not alter performance

Comparing c/12-21-perf_linter_curly_remove_iterating_on_all_nodes (1d5fe56) with c/12-21-perf_linter_curly_avoid_parent_ast_lookup_by_passing_is_do_while_flag (221607f)

Summary

✅ 4 untouched
⏩ 41 skipped1

Footnotes

  1. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@graphite-app graphite-app bot force-pushed the c/12-21-perf_linter_curly_avoid_parent_ast_lookup_by_passing_is_do_while_flag branch from 221607f to c48c406 Compare December 21, 2025 17:57
@graphite-app graphite-app bot force-pushed the c/12-21-perf_linter_curly_remove_iterating_on_all_nodes branch from 1d5fe56 to b8e321c Compare December 21, 2025 17:58
Base automatically changed from c/12-21-perf_linter_curly_avoid_parent_ast_lookup_by_passing_is_do_while_flag to main December 21, 2025 18:02
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 21, 2025
@graphite-app graphite-app bot merged commit b8e321c into main Dec 21, 2025
21 checks passed
@graphite-app graphite-app bot deleted the c/12-21-perf_linter_curly_remove_iterating_on_all_nodes branch December 21, 2025 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linter: poor performance for eslint/curly

1 participant