perf(linter/curly): avoid additional parent AST lookup

[camc314]

Ref #17221

[camc314]

• perf(linter/curly): remove iterating on all nodes #17223
• perf(linter/curly): avoid additional parent AST lookup #17222 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[camc314]

Merge activity

• Dec 21, 5:42 PM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Dec 21, 5:46 PM UTC: camc314 added this pull request to the Graphite merge queue.
• Dec 21, 6:02 PM UTC: Merged by the Graphite merge queue.

[Copilot]

Pull request overview

This PR optimizes the curly linter rule by eliminating an unnecessary parent AST lookup. Instead of querying the AST to determine if a statement is within a do-while loop, the code now passes this information as a boolean parameter derived from the keyword already available in the context.

• Adds an is_do_while parameter to apply_rule_fix to avoid parent node lookup
• Computes is_do_while from the existing keyword parameter using keyword == "do"
• Removes the expensive ctx.nodes().parent_kind() call that was previously needed

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codspeed-hq]

CodSpeed Performance Report

Merging #17222 will not alter performance

_{Comparing c/12-21-perf_linter_curly_avoid_parent_ast_lookup_by_passing_is_do_while_flag (221607f) with main (951a2a2)}

Summary

✅ 4 untouched
⏩ 41 skipped¹

Footnotes

1. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩