Skip to content

feat(oxfmt): Support TOML(v1.0 only) files#17113

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-19-feat_oxfmt_support_toml_files
Dec 19, 2025
Merged

feat(oxfmt): Support TOML(v1.0 only) files#17113
graphite-app[bot] merged 1 commit intomainfrom
12-19-feat_oxfmt_support_toml_files

Conversation

@leaysgur
Copy link
Member

@leaysgur leaysgur commented Dec 19, 2025

Fixes #16907, closes #17048

I will add tests in next PR.
Also, I will add improvement to reduce cloning options.

@github-actions github-actions bot added A-cli Area - CLI A-formatter Area - Formatter C-enhancement Category - New feature or request labels Dec 19, 2025
Copy link
Member Author

leaysgur commented Dec 19, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 19, 2025

CodSpeed Performance Report

Merging #17113 will not alter performance

Comparing 12-19-feat_oxfmt_support_toml_files (ed57ff2) with main (fd57ec3)1

Summary

✅ 42 untouched
⏩ 3 skipped2

Footnotes

  1. No successful run was found on 12-19-refactor_oxfmt_prepare_for_oxfmt-toml_support (83e8dd6) during the generation of this report, so main (fd57ec3) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@leaysgur leaysgur changed the title feat(oxfmt): Support TOML files feat(oxfmt): Support TOML(v1.0 only) files Dec 19, 2025
@leaysgur leaysgur requested a review from Dunqing December 19, 2025 06:16
Copy link
Member

@Boshen Boshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge, I'll clone the repo to remove all the unwanted dependencies.

@leaysgur
Copy link
Member Author

I'll clone the repo to remove all the unwanted dependencies.

You're referring to taplo, right? 👌🏻

@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 19, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 19, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 12-19-refactor_oxfmt_prepare_for_oxfmt-toml_support branch from 83e8dd6 to 750d4b3 Compare December 19, 2025 13:43
@graphite-app graphite-app bot force-pushed the 12-19-feat_oxfmt_support_toml_files branch from ed57ff2 to a3f3c58 Compare December 19, 2025 13:43
Base automatically changed from 12-19-refactor_oxfmt_prepare_for_oxfmt-toml_support to main December 19, 2025 13:49
@graphite-app graphite-app bot merged commit a3f3c58 into main Dec 19, 2025
22 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 19, 2025
@graphite-app graphite-app bot deleted the 12-19-feat_oxfmt_support_toml_files branch December 19, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-formatter Area - Formatter C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

oxfmt: built-in toml formatting

3 participants