refactor(oxfmt): Make support.rs simple#17109
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 19, 2025
Merged
Conversation
github-actions
bot
added
A-cli
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the file format detection logic in oxfmt to prepare for future oxfmt-toml support. The refactoring improves code organization by separating the parser name resolution logic and making the file type detection flow clearer.
- Extracts parser name logic from
get_external_format_sourceinto a newget_external_parser_namefunction that returns just the parser name string - Adds a new
can_format_without_external()method to check if a file can be formatted without external dependencies - Reorganizes the file detection flow in
TryFrom<PathBuf>to be more explicit and sequential
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| apps/oxfmt/src/core/support.rs | Refactors file format detection by extracting parser name resolution into a separate function, adds can_format_without_external() method, and reorganizes the detection flow in TryFrom<PathBuf> |
| apps/oxfmt/src/cli/walk.rs | Updates tier comments to reflect future TOML support and uses the new can_format_without_external() method instead of direct pattern matching |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
leaysgur
force-pushed
the
12-19-refactor_oxfmt_prepare_for_oxfmt-toml_support
branch
2 times, most recently
from
59447a2 to
c845bab
Compare
leaysgur
changed the title
support.rs simple
leaysgur
force-pushed
the
12-19-refactor_oxfmt_prepare_for_oxfmt-toml_support
branch
from
c845bab to
83e8dd6
Compare
This was referenced Dec 19, 2025
Dunqing
approved these changes
Dec 19, 2025
Contributor
Merge activity
|
Also prepare for `toml` support.
graphite-app
bot
force-pushed
the
12-19-refactor_oxfmt_prepare_for_oxfmt-toml_support
branch
from
83e8dd6 to
750d4b3
Compare
graphite-app
bot
deleted the
12-19-refactor_oxfmt_prepare_for_oxfmt-toml_support
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also prepare for
tomlsupport.