test(estree): update estree-conformance submodule#17066
Merged
graphite-app[bot] merged 1 commit intomainfrom Dec 18, 2025
Merged
test(estree): update estree-conformance submodule#17066graphite-app[bot] merged 1 commit intomainfrom
estree-conformance submodule#17066graphite-app[bot] merged 1 commit intomainfrom
Conversation
github-actions
bot
added
the
C-test
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
overlookmotel
added
A-parser
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the estree-conformance and test262 submodules to support token conformance testing introduced in estree-conformance#131.
- Refactored the estree test parser to handle both AST and TOKENS test fixtures
- Updated test262 submodule from commit
947fee33to84082e27, adding 14 new test cases - Updated estree-conformance submodule from commit
e0aa1b46to38117cee
Reviewed changes
Copilot reviewed 1 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tasks/coverage/src/tools/estree.rs | Modified parsing logic to differentiate between AST and TOKENS test blocks; added placeholder for future token validation |
| .github/scripts/clone-parallel.sh | Updated TEST262_SHA and ESTREE_CONFORMANCE_SHA to new commit hashes |
| tasks/coverage/snapshots/transformer_test262.snap | Updated commit hash and test counts (46453→46467) |
| tasks/coverage/snapshots/semantic_test262.snap | Updated commit hash and test counts (46453→46467 total, 44801→44815 passed) |
| tasks/coverage/snapshots/parser_test262.snap | Updated commit hash and test counts (46453→46467 total, 46445→46459 parsed) |
| tasks/coverage/snapshots/minifier_test262.snap | Updated commit hash and test counts (44035→44049) |
| tasks/coverage/snapshots/formatter_test262.snap | Updated commit hash and test counts (46453→46467) |
| tasks/coverage/snapshots/estree_test262.snap | Updated commit hash and test counts (46205→46219) |
| tasks/coverage/snapshots/estree_acorn_jsx.snap | Updated estree-conformance commit hash (e0aa1b46→38117cee) |
| tasks/coverage/snapshots/codegen_test262.snap | Updated commit hash and test counts (46453→46467) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
overlookmotel
force-pushed
the
12-18-test_estree_update_estree-conformance_submodule
branch
from
8e49c39 to
a55cd81
Compare
overlookmotel
changed the base branch from
graphite-base/17066
to
12-18-fix_parser_napi_fix_lazy_deser
overlookmotel
force-pushed
the
12-18-test_estree_update_estree-conformance_submodule
branch
from
a55cd81 to
8ba889a
Compare
Member
Author
Merge activity
|
graphite-app
bot
changed the base branch from
12-18-fix_parser_napi_fix_lazy_deser
to
graphite-base/17066
graphite-app
bot
force-pushed
the
12-18-test_estree_update_estree-conformance_submodule
branch
from
8ba889a to
96cbbae
Compare
graphite-app
bot
force-pushed
the
graphite-base/17066
branch
from
cbd08a8 to
e59132b
Compare
graphite-app
bot
force-pushed
the
12-18-test_estree_update_estree-conformance_submodule
branch
from
96cbbae to
4b5cc12
Compare
Bump `estree-conformance` and `test262` submodules. `estree-conformance` submodule now contains snapshots for tokens conformance testing: oxc-project/estree-conformance#131 & oxc-project/estree-conformance#134
graphite-app
bot
force-pushed
the
12-18-test_estree_update_estree-conformance_submodule
branch
from
4b5cc12 to
d1ce274
Compare
graphite-app
bot
deleted the
12-18-test_estree_update_estree-conformance_submodule
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump
estree-conformanceandtest262submodules.estree-conformancesubmodule now contains snapshots for tokens conformance testing: oxc-project/estree-conformance#131 & oxc-project/estree-conformance#134