Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR creates comprehensive token fixtures for JavaScript/JSX and TypeScript files by adding JSON files containing parsed token information from test files.
- Adds token fixtures for test262 Date.prototype test files (setYear, getYear methods)
- Adds token fixtures for Acorn JSX test file 046
- Uses Espree for JS/JSX token parsing and TS-ESLint for TypeScript tokens
Reviewed changes
Copilot reviewed 64 out of 0 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test262-tokens/test/annexB/built-ins/Date/prototype/setYear/*.json | Token fixtures for Date.prototype.setYear test cases covering various scenarios (absolute years, NaN values, time clipping, etc.) |
| tests/test262-tokens/test/annexB/built-ins/Date/prototype/getYear/*.json | Token fixtures for Date.prototype.getYear test cases (non-Date this values, constructor checks) |
| tests/acorn-jsx/pass/046.tokens.json | Token fixtures for JSX test case with text content containing special characters |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Dec 18, 2025
overlookmotel
added a commit
that referenced
this pull request
Dec 18, 2025
#131 added snapshots for tokens. Remove `range` field from tokens in these snapshots so they match the AST.
graphite-app bot
pushed a commit
to oxc-project/oxc
that referenced
this pull request
Dec 18, 2025
Bump `estree-conformance` and `test262` submodules. `estree-conformance` submodule now contains snapshots for tokens conformance testing: oxc-project/estree-conformance#131 & oxc-project/estree-conformance#134
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create fixtures for tokens.