Skip to content

feat: create tokens fixtures#131

Merged
overlookmotel merged 3 commits intomainfrom
12-18-feat_create_tokens_fixtures
Dec 18, 2025
Merged

feat: create tokens fixtures#131
overlookmotel merged 3 commits intomainfrom
12-18-feat_create_tokens_fixtures

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Dec 18, 2025

Create fixtures for tokens.

  • For JS and JSX, use Espree for parsing tokens.
  • For TS, use TS-ESLint's tokens.

@overlookmotel overlookmotel self-assigned this Dec 18, 2025
@overlookmotel overlookmotel marked this pull request as ready for review December 18, 2025 13:22
Copilot AI review requested due to automatic review settings December 18, 2025 13:22
@overlookmotel overlookmotel merged commit 5595212 into main Dec 18, 2025
1 check passed
@overlookmotel overlookmotel deleted the 12-18-feat_create_tokens_fixtures branch December 18, 2025 13:23
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR creates comprehensive token fixtures for JavaScript/JSX and TypeScript files by adding JSON files containing parsed token information from test files.

  • Adds token fixtures for test262 Date.prototype test files (setYear, getYear methods)
  • Adds token fixtures for Acorn JSX test file 046
  • Uses Espree for JS/JSX token parsing and TS-ESLint for TypeScript tokens

Reviewed changes

Copilot reviewed 64 out of 0 changed files in this pull request and generated no comments.

File Description
tests/test262-tokens/test/annexB/built-ins/Date/prototype/setYear/*.json Token fixtures for Date.prototype.setYear test cases covering various scenarios (absolute years, NaN values, time clipping, etc.)
tests/test262-tokens/test/annexB/built-ins/Date/prototype/getYear/*.json Token fixtures for Date.prototype.getYear test cases (non-Date this values, constructor checks)
tests/acorn-jsx/pass/046.tokens.json Token fixtures for JSX test case with text content containing special characters
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

overlookmotel added a commit that referenced this pull request Dec 18, 2025
#131 added snapshots for tokens. Remove `range` field from tokens in these snapshots so they match the AST.
graphite-app bot pushed a commit to oxc-project/oxc that referenced this pull request Dec 18, 2025
Bump `estree-conformance` and `test262` submodules.

`estree-conformance` submodule now contains snapshots for tokens conformance testing: oxc-project/estree-conformance#131 & oxc-project/estree-conformance#134
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants