Skip to content

feat(linter): implement eslint/max-statements#17010

Closed
qinyuhang wants to merge 4 commits intooxc-project:mainfrom
qinyuhang:feat/eslint/max_statement
Closed

feat(linter): implement eslint/max-statements#17010
qinyuhang wants to merge 4 commits intooxc-project:mainfrom
qinyuhang:feat/eslint/max_statement

Conversation

@qinyuhang
Copy link
Contributor

Ref: #479

This PR implements the https://eslint.org/docs/latest/rules/max-statements

One Question is when I run just ready on my laptop, one fail popup, and I have no idea how to fix it.

$ just ready
...omit_passed...

test size_asserts ... FAILED

...omit_passed...

failures:

---- size_asserts stdout ----

thread 'size_asserts' (6231257) panicked at crates/oxc_linter/src/lib.rs:94:5:
assertion `left == right` failed
  left: 32
 right: 16


failures:
    size_asserts

test result: FAILED. 858 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.94s

error: test failed, to rerun pass `-p oxc_linter --lib`
error: Recipe `test` failed on line 53 with exit code 101
error: Recipe `ready` failed on line 41 with exit code 101

@qinyuhang qinyuhang requested a review from camc314 as a code owner December 17, 2025 14:18
@github-actions github-actions bot added A-linter Area - Linter C-enhancement Category - New feature or request labels Dec 17, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 17, 2025

CodSpeed Performance Report

Merging #17010 will not alter performance

Comparing qinyuhang:feat/eslint/max_statement (bf72528) with main (35070d9)

Summary

✅ 4 untouched
⏩ 41 skipped1

Footnotes

  1. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@camc314 camc314 self-assigned this Dec 18, 2025
@camc314
Copy link
Contributor

camc314 commented Dec 21, 2025

fixed by #15804

@camc314 camc314 closed this Dec 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-linter Area - Linter C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants