feat(linter): implement eslint/max-statements

[pchorus]

Add ESLint rule max-statements.

[graphite-app]

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

[codspeed-hq]

CodSpeed Performance Report

Merging #15804 will not alter performance

_{Comparing pchorus:feature/max-statements (a574cfd) with main (e14db66)¹}

Summary

✅ 4 untouched
⏩ 41 skipped²

Footnotes

1. No successful run was found on main (78df915) during the generation of this report, so e14db66 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

2. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[pchorus]

CI / Test Linux fails with error

thread 'size_asserts' (6658) panicked at crates/oxc_linter/src/lib.rs:94:5:
assertion `left == right` failed
  left: 24
 right: 16

@camc314 Unfortunately, I don't know how to fix this one.

[camc314]

Thank you!

[sebastienbarre]

I'm getting an ocean of errors with this new one. Is there some documentation describing how it is counting statements? This doesn't seem right to me.

[camc314]

I'm getting an ocean of errors with this new one. Is there some documentation describing how it is counting statements? This doesn't seem right to me.

it's a style rule so it might not be for everyone. did you have the eslint rule enabled previously? are the errors the same or different?

I'd suggest disabling this rule in your config (it's not on by default).

[camc314]

I'm getting an ocean of errors with this new one. Is there some documentation describing how it is counting statements? This doesn't seem right to me.

we copied the eslint test cases, so we should have the same behaviours as eslint. Eslint docs:

https://eslint.org/docs/latest/rules/max-statements

[sebastienbarre]

I didn’t have this rule specifically enabled. I disabled it, thanks. I wasn’t using ESLint before. Some of your users might not be ESLint users but Vite fans who got interested in what Void Zero is doing. They might not be aware of these rules or have the foresight to automatically check ESLint for more explanations.