Skip to content

fix(linter): Fix empty-tags rule logic. #16873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Dec 15, 2025
Merged

fix(linter): Fix empty-tags rule logic. #16873

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions crates/oxc_linter/src/rules/jsdoc/empty_tags.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ use serde::Deserialize;
use crate::{
context::LintContext,
rule::{DefaultRuleConfig, Rule},
utils::should_ignore_as_private,
};

fn empty_tags_diagnostic(span: Span, tag_name: &str) -> OxcDiagnostic {
Expand Down Expand Up @@ -103,7 +102,7 @@ impl Rule for EmptyTags {
}

fn run_once(&self, ctx: &LintContext) {
let settings = &ctx.settings().jsdoc;
// NOTE: `ignorePrivate` setting does not apply to this rule.

let is_empty_tag_kind = |tag_name: &str| {
if EMPTY_TAGS.contains(&tag_name) {
Expand All @@ -115,9 +114,9 @@ impl Rule for EmptyTags {
false
};

for jsdoc in
ctx.jsdoc().iter_all().filter(|jsdoc| !should_ignore_as_private(jsdoc, settings))
{
// `ignorePrivate` setting does not apply to `empty-tags` rule,
// so iterate over all JSDoc comments unfiltered.
for jsdoc in ctx.jsdoc().iter_all() {
for tag in jsdoc.tags() {
let tag_name = tag.kind.parsed();

Expand Down Expand Up @@ -358,9 +357,11 @@ fn test() {
",
None,
Some(serde_json::json!({
"jsdoc": {
"ignorePrivate": true,
},
"settings": {
"jsdoc": {
"ignorePrivate": true,
},
}
})),
),
];
Expand Down
Loading