fix(linter): Fix empty-tags rule logic.

[connorshea]

This corrects the implementation of the empty-tags rule to not care about the ignorePrivate setting.

Fixes #16871.

The doc comment for this setting actually explicitly says it should not be considered:

oxc/crates/oxc_linter/src/config/settings/jsdoc.rs

Lines 12 to 14 in 230e34c

	/// For all rules but NOT apply to `check-access` and `empty-tags` rule
	#[serde(default, rename = "ignorePrivate")]
	pub ignore_private: bool,

This was missed when porting the tests because the settings shape was incorrect and silently failed. I only noticed it while attempting to enforce a stricter config schema.

[Copilot]

Pull request overview

This PR fixes the empty-tags rule to correctly ignore the ignorePrivate setting, as documented in the JSDoc settings. The rule was incorrectly filtering JSDoc comments based on the ignorePrivate setting, which should not apply to this rule according to the documented behavior.

Key Changes:

• Removed the should_ignore_as_private utility import and its usage
• Updated iteration logic to process all JSDoc comments without filtering
• Added explanatory comments documenting why ignorePrivate doesn't apply
• Fixed test configuration structure to use proper settings wrapper

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[charliecreates]

The core logic change (stop honoring ignorePrivate) matches the PR intent, but there’s a small performance footgun in is_empty_tag_kind due to repeated to_string() allocations. The updated test config structure is good, but the test suite should include an explicit regression test proving that ignorePrivate: true does not suppress empty-tags diagnostics on @private blocks. Addressing these will make the rule both faster and less likely to regress.

Additional notes (1)

• Performance | crates/oxc_linter/src/rules/jsdoc/empty_tags.rs:108-108
  The current implementation allocates on every tag check via tag_name.to_string() inside the hot path: self.0.tags.contains(&tag_name.to_string()). For large files / many tags this can be unnecessarily expensive. Consider storing configured tags as a set (e.g., FxHashSet<String>) or normalizing to Vec<String> but comparing without allocating (e.g., iterate and compare &str).

Summary of changes

What changed

• Removed the private-filtering logic from jsdoc/empty-tags by dropping utils::should_ignore_as_private and iterating over all JSDoc blocks.
• Added inline documentation clarifying that the ignorePrivate JSDoc setting does not apply to this rule.
• Updated the related test configuration shape to nest ignorePrivate under settings.jsdoc (i.e., {"settings": {"jsdoc": {"ignorePrivate": true}}}) instead of a top-level jsdoc key.

Key diff points

• crates/oxc_linter/src/rules/jsdoc/empty_tags.rs: removed filter(|jsdoc| !should_ignore_as_private(...)) and its settings dependency; updated test config JSON.

[codspeed-hq]

CodSpeed Performance Report

Merging #16873 will not alter performance

_{Comparing fix-empty-tags (02fa857) with main (aafcf3e)¹}

Summary

✅ 4 untouched
⏩ 41 skipped²

Footnotes

1. No successful run was found on main (e0d8001) during the generation of this report, so aafcf3e was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

2. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[camc314]

@connorshea do you mind approving this PR to make sure the change it correct? it looks ok to me, but would appreciate another pair of eyes

Oh wait ignore me, I though copilot made this PR 🙂

[camc314]

Merge activity

• Dec 15, 9:26 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Dec 15, 9:26 AM UTC: camc314 added this pull request to the Graphite merge queue.
• Dec 15, 9:31 AM UTC: Merged by the Graphite merge queue.