Skip to content

fix(semantic): add TS1016 error code to required parameter after optional diagnostic #16685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Dec 10, 2025
Merged

fix(semantic): add TS1016 error code to required parameter after optional diagnostic #16685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions crates/oxc_semantic/src/checker/typescript.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,7 @@ pub fn check_ts_type_alias_declaration<'a>(
}

fn required_parameter_after_optional_parameter(span: Span) -> OxcDiagnostic {
OxcDiagnostic::error("A required parameter cannot follow an optional parameter.")
.with_label(span)
ts_error("1016", "A required parameter cannot follow an optional parameter.").with_label(span)
}

pub fn check_formal_parameters(params: &FormalParameters, ctx: &SemanticBuilder<'_>) {
Expand Down
12 changes: 6 additions & 6 deletions tasks/coverage/snapshots/parser_babel.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,7 @@ Expect to Parse: tasks/coverage/babel/packages/babel-parser/test/fixtures/typesc

Expect to Parse: tasks/coverage/babel/packages/babel-parser/test/fixtures/typescript/class/parameter-properties/input.ts

× A required parameter cannot follow an optional parameter.
× TS(1016): A required parameter cannot follow an optional parameter.
╭─[babel/packages/babel-parser/test/fixtures/typescript/class/parameter-properties/input.ts:7:9]
6 │ private pi?: number,
7 │ public readonly pur,
Expand Down Expand Up @@ -556,7 +556,7 @@ Expect to Parse: tasks/coverage/babel/packages/babel-parser/test/fixtures/typesc

Expect to Parse: tasks/coverage/babel/packages/babel-parser/test/fixtures/typescript/function/declare-pattern-parameters/input.ts

× A required parameter cannot follow an optional parameter.
× TS(1016): A required parameter cannot follow an optional parameter.
╭─[babel/packages/babel-parser/test/fixtures/typescript/function/declare-pattern-parameters/input.ts:1:25]
1 │ declare function f([]?, {})
· ──
Expand Down Expand Up @@ -13171,7 +13171,7 @@ Expect to Parse: tasks/coverage/babel/packages/babel-parser/test/fixtures/typesc
╰────
help: No modifiers are allowed here.

× A required parameter cannot follow an optional parameter.
× TS(1016): A required parameter cannot follow an optional parameter.
╭─[babel/packages/babel-parser/test/fixtures/typescript/class/parameter-properties-not-constructor/input.ts:7:9]
6 │ private pi?: number,
7 │ public readonly pur,
Expand Down Expand Up @@ -13447,21 +13447,21 @@ Expect to Parse: tasks/coverage/babel/packages/babel-parser/test/fixtures/typesc
╰────
help: No modifiers are allowed here.

× A required parameter cannot follow an optional parameter.
× TS(1016): A required parameter cannot follow an optional parameter.
╭─[babel/packages/babel-parser/test/fixtures/typescript/function/parameter-properties/input.ts:6:3]
5 │ private pi?: number,
6 │ public readonly pur,
· ───────────────────
7 │ readonly x = 0,
╰────

× A required parameter cannot follow an optional parameter.
× TS(1016): A required parameter cannot follow an optional parameter.
╭─[babel/packages/babel-parser/test/fixtures/typescript/function/pattern-optional-parameters/input.ts:1:17]
1 │ function f([]?, {}) {}
· ──
╰────

× A required parameter cannot follow an optional parameter.
× TS(1016): A required parameter cannot follow an optional parameter.
╭─[babel/packages/babel-parser/test/fixtures/typescript/function/pattern-optional-parameters-arrow/input.ts:1:7]
1 │ ([]?, {}) => {}
· ──
Expand Down
4 changes: 2 additions & 2 deletions tasks/coverage/snapshots/parser_typescript.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6419,7 +6419,7 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/parser/ecmasc
5 │
╰────

× A required parameter cannot follow an optional parameter.
× TS(1016): A required parameter cannot follow an optional parameter.
╭─[typescript/tests/cases/compiler/fatarrowfunctionsOptionalArgsErrors1.ts:1:9]
1 │ (arg1?, arg2) => 101;
· ────
Expand Down Expand Up @@ -22534,7 +22534,7 @@ Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/parser/ecmasc
╰────
help: No modifiers are allowed here.

× A required parameter cannot follow an optional parameter.
× TS(1016): A required parameter cannot follow an optional parameter.
╭─[typescript/tests/cases/conformance/parser/ecmascript5/ParameterLists/parserParameterList3.ts:2:9]
1 │ class C {
2 │ F(A?, B) { }
Expand Down
Loading