fix(semantic): add TS1016 error code to required parameter after optional diagnostic

[camc314]

I noticed this while looking at https://discord.com/channels/1079625926024900739/1448256490904354931

[camc314]

• fix(semantic): add TS1016 error code to required parameter after optional diagnostic #16685 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Performance Report

Merging #16685 will not alter performance

_{Comparing c/12-10-fix_semantic_add_ts1016_error_code_to_required_parameter_after_optional_diagnostic (e5f53ea) with main (2495a39)¹}

Summary

✅ 42 untouched
⏩ 3 skipped²

Footnotes

1. No successful run was found on main (bd1db8b) during the generation of this report, so 2495a39 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

2. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

[Copilot]

Pull request overview

This PR adds the TypeScript error code TS(1016) to the diagnostic message for "A required parameter cannot follow an optional parameter" error. This improves consistency with TypeScript's official error reporting and helps developers identify and reference this specific error.

Key Changes

• Modified the required_parameter_after_optional_parameter function to use the ts_error helper with error code "1016"
• Updated parser snapshot files to reflect the new error message format with the error code prefix

Reviewed changes

Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.

File	Description
crates/oxc_semantic/src/checker/typescript.rs	Changed from OxcDiagnostic::error() to ts_error("1016", ...) for consistency with other TypeScript diagnostics
tasks/coverage/snapshots/parser_typescript.snap	Updated 2 occurrences of the error message to include TS(1016): prefix
tasks/coverage/snapshots/parser_babel.snap	Updated 6 occurrences of the error message to include TS(1016): prefix

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Boshen]

Merge activity

• Dec 10, 11:56 AM UTC: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Dec 10, 11:56 AM UTC: Boshen added this pull request to the Graphite merge queue.
• Dec 10, 12:07 PM UTC: Merged by the Graphite merge queue.