Skip to content

Comments

refactor(linter/plugins): rename LoadPluginResult#16458

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-03-refactor_linter_plugins_rename_loadpluginresult_
Dec 3, 2025
Merged

refactor(linter/plugins): rename LoadPluginResult#16458
graphite-app[bot] merged 1 commit intomainfrom
12-03-refactor_linter_plugins_rename_loadpluginresult_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Dec 3, 2025

Pure refactor. Rename PluginLoadResult to LoadPluginResult. The function that returns it is called load_plugin, so this naming makes more sense.

Copy link
Member Author

overlookmotel commented Dec 3, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 3, 2025

CodSpeed Performance Report

Merging #16458 will not alter performance

Comparing 12-03-refactor_linter_plugins_rename_loadpluginresult_ (08187e7) with main (9001234)1

Summary

✅ 4 untouched
⏩ 41 skipped2

Footnotes

  1. No successful run was found on 12-03-refactor_linter_plugins_move_lintfilereturnvalue_struct_to_above_wrap_lint_file_ (9992bac) during the generation of this report, so main (9001234) was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 41 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@overlookmotel overlookmotel marked this pull request as ready for review December 3, 2025 17:21
Copilot AI review requested due to automatic review settings December 3, 2025 17:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR performs a pure refactor by renaming PluginLoadResult to LoadPluginResult across the linter's external plugin system. The new naming aligns with the established convention where result types follow the VerbNounResult pattern matching their associated function names (e.g., load_pluginLoadPluginResult, similar to lint_fileLintFileResult).

  • Renamed the enum type from PluginLoadResult to LoadPluginResult
  • Updated all imports and usages across the crates
  • Maintained consistency with existing naming patterns

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
crates/oxc_linter/src/lib.rs Updated public export of the renamed type
crates/oxc_linter/src/external_linter.rs Renamed enum definition and updated type alias ExternalLinterLoadPluginCb
crates/oxc_linter/src/config/config_builder.rs Updated import statement and pattern matching in load_external_plugin function
apps/oxlint/src/js_plugins/external_linter.rs Updated import and deserialization call in wrap_load_plugin function

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@overlookmotel overlookmotel changed the base branch from 12-03-refactor_linter_plugins_move_lintfilereturnvalue_struct_to_above_wrap_lint_file_ to graphite-base/16458 December 3, 2025 17:30
@overlookmotel overlookmotel force-pushed the 12-03-refactor_linter_plugins_rename_loadpluginresult_ branch from 6ccb6a4 to 08187e7 Compare December 3, 2025 17:30
@overlookmotel overlookmotel changed the base branch from graphite-base/16458 to 12-03-refactor_linter_plugins_move_lintfilereturnvalue_struct_to_above_wrap_lint_file_ December 3, 2025 17:30
@overlookmotel overlookmotel self-assigned this Dec 3, 2025
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label Dec 3, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 3, 2025

Merge activity

Pure refactor. Rename `PluginLoadResult` to `LoadPluginResult`. The function that returns it is called `load_plugin`, so this naming makes more sense.
@graphite-app graphite-app bot force-pushed the 12-03-refactor_linter_plugins_move_lintfilereturnvalue_struct_to_above_wrap_lint_file_ branch from 9992bac to 34dacba Compare December 3, 2025 19:08
@graphite-app graphite-app bot force-pushed the 12-03-refactor_linter_plugins_rename_loadpluginresult_ branch from 08187e7 to 0df6e73 Compare December 3, 2025 19:08
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 3, 2025
Base automatically changed from 12-03-refactor_linter_plugins_move_lintfilereturnvalue_struct_to_above_wrap_lint_file_ to main December 3, 2025 19:17
@graphite-app graphite-app bot merged commit 0df6e73 into main Dec 3, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 12-03-refactor_linter_plugins_rename_loadpluginresult_ branch December 3, 2025 19:18
taearls pushed a commit to taearls/oxc that referenced this pull request Dec 11, 2025
Pure refactor. Rename `PluginLoadResult` to `LoadPluginResult`. The function that returns it is called `load_plugin`, so this naming makes more sense.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-cli Area - CLI A-linter Area - Linter C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants