refactor(linter/plugins): rename LoadPluginResult#16458
refactor(linter/plugins): rename LoadPluginResult#16458graphite-app[bot] merged 1 commit intomainfrom
LoadPluginResult#16458Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Performance ReportMerging #16458 will not alter performanceComparing Summary
Footnotes
|
There was a problem hiding this comment.
Pull request overview
This PR performs a pure refactor by renaming PluginLoadResult to LoadPluginResult across the linter's external plugin system. The new naming aligns with the established convention where result types follow the VerbNounResult pattern matching their associated function names (e.g., load_plugin → LoadPluginResult, similar to lint_file → LintFileResult).
- Renamed the enum type from
PluginLoadResulttoLoadPluginResult - Updated all imports and usages across the crates
- Maintained consistency with existing naming patterns
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
crates/oxc_linter/src/lib.rs |
Updated public export of the renamed type |
crates/oxc_linter/src/external_linter.rs |
Renamed enum definition and updated type alias ExternalLinterLoadPluginCb |
crates/oxc_linter/src/config/config_builder.rs |
Updated import statement and pattern matching in load_external_plugin function |
apps/oxlint/src/js_plugins/external_linter.rs |
Updated import and deserialization call in wrap_load_plugin function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3330bb1 to
9992bac
Compare
6ccb6a4 to
08187e7
Compare
Merge activity
|
Pure refactor. Rename `PluginLoadResult` to `LoadPluginResult`. The function that returns it is called `load_plugin`, so this naming makes more sense.
9992bac to
34dacba
Compare
08187e7 to
0df6e73
Compare
Pure refactor. Rename `PluginLoadResult` to `LoadPluginResult`. The function that returns it is called `load_plugin`, so this naming makes more sense.

Pure refactor. Rename
PluginLoadResulttoLoadPluginResult. The function that returns it is calledload_plugin, so this naming makes more sense.